1140188 - Update meta tags on Firefox OS pages

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, enhancement)

Description

[Kohei Yoshino [:kohei]]

+++ This bug was initially created as a clone of Bug #1140186 +++

https://www.mozilla.org/firefox/os/

The copy is in Bug 1131216, graphic TBD.

Comment 1

[Francesco Lodolo [:flod]]

Can you explain exactly what is going to change? Because new title and description are currently in a pending PR from agibson (we failed to update them at launch).

Comment 2

[Francesco Lodolo [:flod]]

Ref: https://github.com/mozilla/bedrock/pull/2816

Comment 3

[Kohei Yoshino [:kohei]]

This is the proposal:

Title: Firefox OS
Description: We’re going beyond Firefox on computers. Firefox OS is a new operating system on the market. Explore. Learn. Enjoy. 
Image: provided in Bug 113121

Comment 4

[Kohei Yoshino [:kohei]]

Ah, I meant Bug 1131216.

Comment 5

[Jennifer Bertsch [:jbertsch]]

(In reply to Kohei Yoshino [:kohei] from comment #3)
> This is the proposal:
> 
> Title: Firefox OS
> Description: We’re going beyond Firefox on computers. Firefox OS is a new
> operating system on the market. Explore. Learn. Enjoy. 
> Image: provided in Bug 113121

Asking Matej for input.

Comment 6

[Matej Novak [:matej]]

(In reply to Jennifer Bertsch [:jbertsch] from comment #5)
> (In reply to Kohei Yoshino [:kohei] from comment #3)
> > This is the proposal:
> > 
> > Title: Firefox OS
> > Description: We’re going beyond Firefox on computers. Firefox OS is a new
> > operating system on the market. Explore. Learn. Enjoy. 
> > Image: provided in Bug 113121
> 
> Asking Matej for input.

This doesn't feel exactly right. Let's try this instead:

Title: Firefox OS
Description: Designed to give you just what you need in a smartphone, with apps for all you do and more. Smart has never been so simple.

Comment 7

[Francesco Lodolo [:flod]]

Let's make sure Alex is aware of this at this point.

Comment 8

[Alex Gibson [:agibson]]

Let's save duplicating work here - I'll update these strings in the PR above. Thanks, Flod

Comment 9

[Alex Gibson [:agibson]]

Kohei, don't worry about picking up this change. I can take care of it in the PR that's already pending to change these strings. Thanks anyway :)

Comment 10

[Kohei Yoshino [:kohei]]

Thanks! We still need the image, see Bug 1131216 Comment 17. I guess it can be the default page image for the pages under /firefox/os/, like the Firefox image (Bug 1140186). Is that okay for you, William?

The following templates need to be changed:

> bedrock/firefox/templates/firefox/fxos-base.html
> bedrock/firefox/templates/firefox/os/devices.html
> bedrock/firefox/templates/firefox/os/faq.html
> bedrock/firefox/templates/firefox/os/mwc-2015-preview.html
> bedrock/firefox/templates/firefox/os/tv.html

Comment 11

[William Reynolds [:williamr]]

(In reply to Kohei Yoshino [:kohei] from comment #10)
> Thanks! We still need the image, see Bug 1131216 Comment 17. I guess it can
> be the default page image for the pages under /firefox/os/, like the Firefox
> image (Bug 1140186). Is that okay for you, William?
> 
> The following templates need to be changed:
> 
> > bedrock/firefox/templates/firefox/fxos-base.html
> > bedrock/firefox/templates/firefox/os/devices.html
> > bedrock/firefox/templates/firefox/os/faq.html
> > bedrock/firefox/templates/firefox/os/mwc-2015-preview.html
> > bedrock/firefox/templates/firefox/os/tv.html

Yes, that is perfect. Great suggestion, Kohei.

The image is now ready too :)

Comment 12

[Alex Gibson [:agibson]]

Kohei, to reduce the scope of the PR already open let's keep Bug 140168 separate, as it touches more pages. This bug is only related to firefox/os.

Comment 13

[Alex Gibson [:agibson]]

Sorry, that I meant 1140186

Comment 14

[Kohei Yoshino [:kohei]]

Yes, I'll send a different PR for Bug 1140186.

Comment 15

[Alex Gibson [:agibson]]

Gah, sorry I misread your comment - Kohei, I'm happy to update the strings seeing as this PR is already in process. If you would like to update the other pages, please feel free to reassign this bug to yourself.

Comment 16

[Kohei Yoshino [:kohei]]

Ah, so I'll send a different PR just to add the image to all the pages under /firefox/os/, as your PR already has page_title and page_desc which can be updated easily.

Comment 17

[Alex Gibson [:agibson]]

Thanks, Kohei - I wasn't aware updating the images on all the above URL's was a requirement of this bug until Comment 10. Let's do a separate PR for this to keep things simple for review. I can take care of the strings. Thanks

Comment 18

[Kohei Yoshino [:kohei]]

Attachment: pull request to add the page image

Comment 19

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/168652ca1d8382387ae55f64d5822a6f2030ddff
Add page image to Firefox OS pages, part of Bug 1140188

https://github.com/mozilla/bedrock/commit/05851cc0833d21d9532cd0af56fa9cead06611e4
Merge pull request #2824 from kyoshino/bug-1140188-fxos-meta

Add page image to Firefox OS pages, part of Bug 1140188

Comment 20

[Lizz Noonan - she/her (:lizzn)]

Hey all! Since the pull request went through, can we resolve this bug? 

Thanks!
Lizz

Comment 21

[Kohei Yoshino [:kohei]]

Yes, closing!