1140261 - gecko/ipc/keystore/KeyStore.cpp:142:27: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Fix compiler error comparison of unsigned expression >= 0 is always true

KeyStore is an implementation corresponding to keystore daemon in Android [1], to support certificate/private key access from wpa_supplicant.
And I think we need another person to keep KeyStore functional except me.

Since KeyStore is a part of Wifi, Henry, I would like to have you involved if you are interested.

[1] http://androidxref.com/5.0.0_r2/xref/system/security/keystore/

Comment 2

[Henry Chang [:hchang]]

Comment on attachment 8574366 [details] [diff] [review]
Fix compiler error comparison of unsigned expression >= 0 is always true

Review of attachment 8574366 [details] [diff] [review]:
-----------------------------------------------------------------

r+ after fixing the typo. Thanks!

::: ipc/keystore/KeyStore.cpp
@@ +149,2 @@
>                           &signResultSize);
>  

Do you mean 

int32_t ret = sign(name, signData, (size_t)(signDataSize), &signResult,
                   &signResultSize);

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Fix compiler error comparison of unsigned expression >= 0 is always true. V2. r=hchang

Oooooops and thanks, Henry!

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de127e2df711

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try looks good.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e25c3139edca

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e25c3139edca