[Stingray] Unable to pop up app install dialog

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dwi2, Assigned: dwi2)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
When we try to install app, app install dialog is unable to pop up. Instead we get this error: 
JavaScript error: app://smart-system.gaiamobile.org/tv_shared/js/simple_key_navigation.js, line 25: TypeError: options is undefined
(Assignee)

Comment 1

3 years ago
This is due to recently we have third argument in simpleKeyNavigation.start(). However, there is no third argument provided in tv_apps/smart-system/js/app_install_manager.js
(Assignee)

Updated

3 years ago
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Created attachment 8573747 [details] [review]
[gaia] dwi2:bug1140280 > mozilla-b2g:master
(Assignee)

Comment 3

3 years ago
Comment on attachment 8573747 [details] [review]
[gaia] dwi2:bug1140280 > mozilla-b2g:master

Hi John,

Please help to review the patch, thanks
Attachment #8573747 - Flags: review?(im)
Comment on attachment 8573747 [details] [review]
[gaia] dwi2:bug1140280 > mozilla-b2g:master

Looks good to me. Sung and I had found the same issue while writing patches for focus issues.
Attachment #8573747 - Flags: review?(im) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.