Closed
Bug 1140280
Opened 9 years ago
Closed 9 years ago
[Stingray] Unable to pop up app install dialog
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: dwi2)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
When we try to install app, app install dialog is unable to pop up. Instead we get this error: JavaScript error: app://smart-system.gaiamobile.org/tv_shared/js/simple_key_navigation.js, line 25: TypeError: options is undefined
Assignee | ||
Comment 1•9 years ago
|
||
This is due to recently we have third argument in simpleKeyNavigation.start(). However, there is no third argument provided in tv_apps/smart-system/js/app_install_manager.js
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8573747 [details] [review] [gaia] dwi2:bug1140280 > mozilla-b2g:master Hi John, Please help to review the patch, thanks
Attachment #8573747 -
Flags: review?(im)
Comment 4•9 years ago
|
||
Comment on attachment 8573747 [details] [review] [gaia] dwi2:bug1140280 > mozilla-b2g:master Looks good to me. Sung and I had found the same issue while writing patches for focus issues.
Attachment #8573747 -
Flags: review?(im) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/4ef1fa9b2870499fc9c77cac4a15f62e12a3ad2c
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•