Closed Bug 1140281 Opened 5 years ago Closed 5 years ago

[Customizer] repeatedly opening and closing the customizer degrades performance

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: djf, Assigned: djf)

References

Details

(Whiteboard: [spark])

Attachments

(2 files)

We don't release the click event handler or the mutation observer or delete the gaia-dom-tree contents when we close the customizer. So things get slower and slower each time.
Priority: -- → P1
Doug: I'm asking for your review on this because it is related to the sluggishness in bug 1140095.

But Justin, you would be a good reviewer too.

If it looks good, just go ahead and land it.
Assignee: nobody → dflanagan
Flags: needinfo?(jdarcangelo)
Attachment #8573748 - Flags: review?(drs.bugzilla)
Doug, it looks like you're recently the most active contributor to this repo. Would you review this one as well, please?
Attachment #8573750 - Flags: review?(drs.bugzilla)
Blocks: 1140095
Comment on attachment 8573750 [details] [review]
gaia-dom-tree patch to allow us to clear the tree when root is null

If we want to be serious about reviews, Wilson should be the one to review this, but it's not important in this case.
Attachment #8573750 - Flags: review?(drs.bugzilla) → review+
Attachment #8573748 - Flags: review?(drs.bugzilla) → review+
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
Clearing NI? since this has been resolved.
Flags: needinfo?(jdarcangelo)
You need to log in before you can comment on or make changes to this bug.