Remove __noSuchMethod__ from url-classifier/content/moz/debug.js

RESOLVED FIXED in Firefox 39

Status

()

Toolkit
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla39
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8573863 [details] [diff] [review]
Patch

__noSuchMethod__ is a non-standard feature that we want to remove from SpiderMonkey.

Gavin, I'm not sure who should review this, the file hasn't been modified much since the switch to hg.

Also, it looks like G_debugService is only used in #ifdef DEBUG code, so I'm not sure if stubbing these functions in non-DEBUG builds is even necessary, but this seemed the safest fix.
Attachment #8573863 - Flags: review?(gavin.sharp)
Comment on attachment 8573863 [details] [diff] [review]
Patch

Scary that I think this code is mostly untested, but this looks complete.
Attachment #8573863 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb7d748abbe8
https://hg.mozilla.org/mozilla-central/rev/cb7d748abbe8
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.