Closed Bug 1140346 Opened 10 years ago Closed 10 years ago

Updated rejected theme with reason 9 gives error 500 when reviewing

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Product:
addons.mozilla.org Graveyard
Component:
Admin/Editor Tools
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2015-03

People

(Reporter: magopian, Assigned: magopian)

Details

STR: 1/ upload a theme 2/ reject it with the reason 9 (Header image alignment problem ) 3/ update the theme so it appears again in the "updates" theme queue 4/ click on the theme to review it 5/ there is an "oops" page This is because in the template the "reject reasons" is a list and not a dict (entry 9 in the dict is the 8th entry in the 0-based list).
PR: https://github.com/mozilla/olympia/pull/466
Assignee: nobody → mathieu
Fixed in https://github.com/mozilla/olympia/commit/382d86f1cfab61899080a23dce31b8917532fd45
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified as fixed : http://screencast.com/t/gOGXxt2fq
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.