1140348 - TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/findmydevice/test/marionette/findmydevice_test.js | Find My Device lock > Lock the screen through the test app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Alberto Pastor [:albertopq]]

http://ftp.mozilla.org/pub/mozilla.org/b2g/try-builds/gaiabld-35bfef0d0fcd/gaia-try-linux64_gecko/gaia-try_ubuntu64_vm-b2gdt_test-gaia-js-integration-3-bm53-tests1-linux64-build86.txt.gz

Comment 1

[Alberto Pastor [:albertopq]]

Hi Guilherme,

It seems that one FindMyDevice test is failing in v2.1. I think it started failing after bug 1062558 uplift. Could you please take a look? Thanks!

Comment 2

[Guilherme Gonçalves [:ggp]]

I think this is caused by the fact that FMD is not enabled during the test, so it is not listening for "lockscreen-appclosed" [1], which would have caused the lockscreen message to be cleared. I believe the best way to fix this would be to have the FMD test app enable FMD when opened, and restore the enabled state when closed.

I've left Mozilla a few months ago, and as a volunteer, my time is a pretty limited these days. Sherman, since you worked on the original uplift, would you be interested in working on this? I'll be happy to review.

1- https://github.com/mozilla-b2g/gaia/blob/v2.1/apps/system/js/findmydevice_launcher.js#L123

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] shamenchens:Bug1140348-FMDIntegrationTestFailed > mozilla-b2g:v2.1

Comment 4

[Sherman Chen [:chens] (inactive)]

This patch should solve findmydevice failure on gij-3, but sometimes I got harness failure, let's see how it works: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=1e259834a608

Comment 5

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8574197 [details] [review]
[gaia] shamenchens:Bug1140348-FMDIntegrationTestFailed > mozilla-b2g:v2.1

Hi Guilherme, could you help to review it? I've also tested on local machine and verified it can solve fmd integration test failures. `make test-integration-test APP=findmydevice` will fail without this patch and pass with this patch. 

I'm still getting harness failure on gij-3[1], but I found Alberto's pr got different result[2]. I think Alberto's pr solve harness failure problem and my pr should land after that, ni Alberto to confirm my guess.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=1e259834a608
[2]: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=746e27fc4d34

Comment 6

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8574197 [details] [review]
[gaia] shamenchens:Bug1140348-FMDIntegrationTestFailed > mozilla-b2g:v2.1

Thanks for the patch!

I think your approach in this patch should work, but a more complete fix would be to change the test app, not the test.

Can we make the test app (you'll find it in dev_apps/test-findmydevice/) set "findmydevice.enabled" to true when opened, saving the old value of the setting, then restore that old value when closed?

That way the test app will work the same way when used manually and from marionette, and the test can stay as it is.

Comment 7

[Sherman Chen [:chens] (inactive)]

I got different thoughts, it doesn't make sense to me to change settings value when test-findmydevice is opened/closed. Test app should honor settings value retrieved from real device or marionette client, not changing them directly. How do you think?

Comment 8

[Alberto Pastor [:albertopq]]

That's correct, :chens. The error you are seeing is being tracked on https://bugzilla.mozilla.org/show_bug.cgi?id=1138978.

Thanks!

Comment 9

[Guilherme Gonçalves [:ggp]]

(In reply to Sherman Chen [:chens] from comment #7)
> I got different thoughts, it doesn't make sense to me to change settings
> value when test-findmydevice is opened/closed. Test app should honor
> settings value retrieved from real device or marionette client, not changing
> them directly. How do you think?

I personally think it would be nice to keep the test app working outside of the test just like it works inside it, but I don't feel too strongly about this, mostly because I believe no-one is using the test app manually anyway. I chatted with :gerard-majax about this, and he agrees with you. So let's go with your solution.

Comment 10

[Guilherme Gonçalves [:ggp]]

I probably need you to r? me again so I can r+ though :)

Comment 11

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8574197 [details] [review]
[gaia] shamenchens:Bug1140348-FMDIntegrationTestFailed > mozilla-b2g:v2.1

Thank you Guilherme, would you review this again? 

I will push to gaia-try and verify this after bug 1138978 is landed so we can make sure it's been properly fixed.

Comment 12

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8574197 [details] [review]
[gaia] shamenchens:Bug1140348-FMDIntegrationTestFailed > mozilla-b2g:v2.1

Thanks!

Comment 13

[Sherman Chen [:chens] (inactive)]

Steal this bug from Alberto ;)

Gaia-try result: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=f83ea82bc534
Seems there's no fmd failures, and other unexpected failures have bugs tracking so I'm landing this.

2.1: https://github.com/mozilla-b2g/gaia/commit/9f2f64bbc9f29edb36f8cbf57d4e0c3f4dee3124

Comment 14

[Vincent Liu[:vliu]]

v2.1s : https://git.mozilla.org/?p=releases/gaia.git;a=commit;h=e3373dce7cbd5e4bb391084867c545638e39a2aa