Remove __noSuchMethod__ from the Add-on SDK

RESOLVED FIXED in Firefox 39

Status

Add-on SDK
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla39
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
erikvold
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
__noSuchMethod__ is a non-standard feature that we want to remove from SpiderMonkey.

Fortunately, the 3 uses in the SDK are all easy to convert. Pull request coming up.
(Assignee)

Updated

3 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 1

3 years ago
Created attachment 8573901 [details] [review]
pull request
Attachment #8573901 - Flags: review?(evold)
(Assignee)

Comment 2

3 years ago
Erik, Travis didn't like my pull request. It's possible we have to wait until bug 1139794 is on m-c...

Unfortunately, when I run the tests locally [0] with a recent Nightly and unmodified addon-sdk source code, I also get various test failures, so I've no idea how I can track this down.

What should I do? Can I also just land my patches on m-c?

[0] cfx testall --binary FirefoxNightly.app
Depends on: 1139794
Flags: needinfo?(evold)
Flags: needinfo?(evold)
Attachment #8573901 - Flags: review?(evold) → review+
(In reply to Jan de Mooij [:jandem] from comment #2)
> Erik, Travis didn't like my pull request. It's possible we have to wait
> until bug 1139794 is on m-c...

That looks like the case.

> Unfortunately, when I run the tests locally [0] with a recent Nightly and
> unmodified addon-sdk source code, I also get various test failures, so I've
> no idea how I can track this down.
> 
> What should I do? Can I also just land my patches on m-c?

You can land on m-c, or wait until that lands in nightly
(Assignee)

Comment 4

3 years ago
(In reply to Erik Vold [:erikvold] (please needinfo? me) from comment #3)
> You can land on m-c, or wait until that lands in nightly

Thanks, pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/51c04665cb6e
https://hg.mozilla.org/mozilla-central/rev/51c04665cb6e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39

Comment 6

3 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1ac10e940429886485af973eb2e114e4a7e10343
Bug 1140361 - Remove __noSuchMethod__ from the add-on SDK. r=erikvold
You need to log in before you can comment on or make changes to this bug.