1140368 - UI bug for "Display Attachments Inline" (MenuBar and App Menu independently updates Checked/Unchecked mark of "Display Attachments Inline")

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Spampot]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150305021524

Steps to reproduce:

System: Thunderbird 31.5.0 on Windows (verified for Windows XP-32 and 8.1-64)

1. Start Thunderbird and review the state of the "View\Display Attachments Inline" option in the "classic" window menu (which appears when you press the ALT key) and in the "new" menu (from the right-most toolbar button).

2. Change the "Display Attachments Inline" option in one menu and watch the effect in the respective other menu.


Actual results:

1. After a fresh start, the classic menu shows the correct state of the "Display Attachments Inline" option (checked or unchecked), while it is ALWAYS checked in the new menu.

2. When the option is checked or unchecked in the classic menu, the new menu is NOT updated accordingly (the option remains as it was before). However, when the option is changed in the new menu, it is also updated in the classic menu.


Expected results:

The option should display correctly in both menus, both after a fresh start of Thunderbird and after it has been changed in either menu.

Comment 1

[WADA:World Anti-bad-Duping Agency]

(In reply to Spampot from comment #0)
> in the "new" menu (from the right-most toolbar button).

Hamberger button or "三" button("App Menu"  is stored in Cutomize Toolbar panel, "Tooltip=Disply the Thunderbird menu)?

>  (which appears when you press the ALT key) 

For ease of checking, show "MenuBar" via Customize Toolbar.

Confusing behavior is confirmed..

Current behavior of the menu.
  When menu is clicked, each menu does do;
     1. toggle "View/Display/Attachments Inline" option setting
     2. Show state of  the "View/Display/Attachments Inline" option setting by "Checked/Unchecked mark" at my own menu.
     3. Doesn't "Checked/Unchecked mark" of other menu.
  i.e. Each menu shows "Checked/Unchecked mark" which was set when the menu was clicked last time.
        Meaning of Checked mark     : When I was clicked last time, I changed to Checked 
        Meaning of Unchecked mark : When I was clicked last time, I changed to Unchecked.

A solution : Reflect current "View/Display/Attachments Inline" option setting to my menu by script of onpopupshowing.
Already reported?

Comment 2

[:aceman]

Yeah, the menuitems are not kept in sync:
http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.js#2507

Comment 3

[:aceman]

Attachment: patch

I can confirm what the original reporter said. The main menu shows the correct state of the pref. The appmenu toggles only when clicked. At startup it does not show the correct state.

This patch should fix it.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8574779 [details] [diff] [review]
patch

Review of attachment 8574779 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 5

[Kent James (:rkent)]

Seems like a simple fix we could push to TB 38, right?

Comment 6

[:aceman]

Yes, probably shouldn't hurt.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/comm-central/rev/edafc098a2a3

Comment 8

[Kent James (:rkent)]

Comment on attachment 8574779 [details] [diff] [review]
patch

https://hg.mozilla.org/releases/comm-aurora/rev/fcf4eb0a177d