UI bug for "Display Attachments Inline" (MenuBar and App Menu independently updates Checked/Unchecked mark of "Display Attachments Inline")

RESOLVED FIXED in Thunderbird 39.0

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Spampot, Assigned: aceman)

Tracking

({polish})

31 Branch
Thunderbird 39.0
x86
Windows XP
polish

Thunderbird Tracking Flags

(thunderbird38+ fixed, thunderbird39 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150305021524

Steps to reproduce:

System: Thunderbird 31.5.0 on Windows (verified for Windows XP-32 and 8.1-64)

1. Start Thunderbird and review the state of the "View\Display Attachments Inline" option in the "classic" window menu (which appears when you press the ALT key) and in the "new" menu (from the right-most toolbar button).

2. Change the "Display Attachments Inline" option in one menu and watch the effect in the respective other menu.


Actual results:

1. After a fresh start, the classic menu shows the correct state of the "Display Attachments Inline" option (checked or unchecked), while it is ALWAYS checked in the new menu.

2. When the option is checked or unchecked in the classic menu, the new menu is NOT updated accordingly (the option remains as it was before). However, when the option is changed in the new menu, it is also updated in the classic menu.


Expected results:

The option should display correctly in both menus, both after a fresh start of Thunderbird and after it has been changed in either menu.
(In reply to Spampot from comment #0)
> in the "new" menu (from the right-most toolbar button).

Hamberger button or "三" button("App Menu"  is stored in Cutomize Toolbar panel, "Tooltip=Disply the Thunderbird menu)?

>  (which appears when you press the ALT key) 

For ease of checking, show "MenuBar" via Customize Toolbar.

Confusing behavior is confirmed..

Current behavior of the menu.
  When menu is clicked, each menu does do;
     1. toggle "View/Display/Attachments Inline" option setting
     2. Show state of  the "View/Display/Attachments Inline" option setting by "Checked/Unchecked mark" at my own menu.
     3. Doesn't "Checked/Unchecked mark" of other menu.
  i.e. Each menu shows "Checked/Unchecked mark" which was set when the menu was clicked last time.
        Meaning of Checked mark     : When I was clicked last time, I changed to Checked 
        Meaning of Unchecked mark : When I was clicked last time, I changed to Unchecked.

A solution : Reflect current "View/Display/Attachments Inline" option setting to my menu by script of onpopupshowing.
Already reported?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: UI bug for "Display Attachments Inline" → UI bug for "Display Attachments Inline" (MenuBar and App Menu independently updates Checked/Unchecked mark of "Display Attachments Inline")
(Assignee)

Comment 2

4 years ago
Yeah, the menuitems are not kept in sync:
http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.js#2507
Assignee: nobody → acelists
Component: Untriaged → Mail Window Front End
(Assignee)

Comment 3

4 years ago
Created attachment 8574779 [details] [diff] [review]
patch

I can confirm what the original reporter said. The main menu shows the correct state of the pref. The appmenu toggles only when clicked. At startup it does not show the correct state.

This patch should fix it.
Attachment #8574779 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8574779 [details] [diff] [review]
patch

Review of attachment 8574779 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #8574779 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
Keywords: checkin-needed, polish

Comment 5

4 years ago
Seems like a simple fix we could push to TB 38, right?
tracking-thunderbird38: --- → +
(Assignee)

Comment 6

4 years ago
Yes, probably shouldn't hurt.
https://hg.mozilla.org/comm-central/rev/edafc098a2a3
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-thunderbird39: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0

Updated

4 years ago
status-thunderbird38: --- → fixed
You need to log in before you can comment on or make changes to this bug.