Closed
Bug 1140429
Opened 11 years ago
Closed 11 years ago
Non-skipped B2G/Mulet R6 reftests "needs-focus" fails because of B2G caret
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
2.2 S8 (20mar)
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files, 2 obsolete files)
|
93.52 KB,
image/png
|
Details | |
|
4.13 KB,
patch
|
gerard-majax
:
review+
|
Details | Diff | Splinter Review |
Some tests that are tagged 'needs-focus' fails. Generated screenshot shows we have the B2G caret visible, hence explaining the failure.
This is blocking green R6 mulet.
| Assignee | ||
Comment 1•11 years ago
|
||
| Assignee | ||
Comment 2•11 years ago
|
||
> editor/reftests/reftest.list:skip-if(Mulet) needs-focus == input-text-onfocus-reframe.html input-text-onfocus-reframe-ref.html # TODO: Mulet failure
> editor/reftests/reftest.list:skip-if(Mulet) needs-focus == input-text-notheme-onfocus-reframe.html input-text-notheme-onfocus-reframe-ref.html # TODO: Mulet failure
> editor/reftests/reftest.list:skip-if(Mulet) needs-focus == 824080-2.html 824080-2-ref.html # TODO: Mulet failure
| Assignee | ||
Comment 3•11 years ago
|
||
Toggling the pref selectioncaret.enabled to false does locally make disappear the caret.
| Assignee | ||
Comment 4•11 years ago
|
||
| Assignee | ||
Comment 5•11 years ago
|
||
| Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba18fb3e73d7
broken for a typo on bug 1139895
| Assignee | ||
Comment 7•11 years ago
|
||
| Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #7)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=7638cc996f21
Looks like we need to disable both.
Testing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=48fa26bff7d4
| Assignee | ||
Updated•11 years ago
|
Attachment #8573980 -
Flags: review?(ehsan)
Updated•11 years ago
|
Attachment #8573980 -
Flags: review?(ehsan) → review+
| Assignee | ||
Comment 9•11 years ago
|
||
| Assignee | ||
Comment 10•11 years ago
|
||
| Assignee | ||
Updated•11 years ago
|
Attachment #8574382 -
Attachment is obsolete: true
| Assignee | ||
Updated•11 years ago
|
Attachment #8573980 -
Attachment is obsolete: true
| Assignee | ||
Comment 11•11 years ago
|
||
Comment on attachment 8574383 [details] [diff] [review]
Force disable caret prefs for needs-focus reftests r=ehsan
Carrying r+, updating bug title
Attachment #8574383 -
Flags: review+
| Assignee | ||
Comment 12•11 years ago
|
||
Keywords: checkin-needed
Comment 13•11 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S8 (20mar)
Updated•11 years ago
|
Whiteboard: [systemsfe]
You need to log in
before you can comment on or make changes to this bug.
Description
•