1140488 - [NFC] Remove _triggerP2PUI from NfcManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

After moving ShrinkingUI away from system app (Bug 1050164) _triggerP2PUI is not used anymore. It should be removed, additionally the comments describing the sharing process should be updated to reflect the current situation.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] tauzen:Bug1140488_triggerP2PUI_removal > mozilla-b2g:master

Comment 2

[Krzysztof Mioduszewski[:tauzen]]

Comment on attachment 8574645 [details] [review]
[gaia] tauzen:Bug1140488_triggerP2PUI_removal > mozilla-b2g:master

Hi Greg, this is some small clean up, needed after introducing the SharingUI lib. Could you review this? Thanks!

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

(In reply to Krzysztof Mioduszewski[:tauzen] from comment #2)
> needed after introducing the SharingUI lib.
s/SharingUI/ShrinkingUI

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8574645 [details] [review]
[gaia] tauzen:Bug1140488_triggerP2PUI_removal > mozilla-b2g:master

The patch is good I think. However, to make autolander works, you need to find another enlisted peer/owner to r+ your patch. You can ask :alive since he is the onwer of System app.

Comment 5

[Krzysztof Mioduszewski[:tauzen]]

Thanks Greg, I had some discussion with :kgrandon and :timdream about autolander last week, as a result I should be listed for NFC. So let's try this.

Comment 6

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/ecae64acb976f09ee3e72206c47406026338e41c