Closed Bug 1140499 Opened 7 years ago Closed 7 years ago

IPC Proxy for text/char bounds

Categories

(Core :: Disability Access APIs, defect)

36 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(2 files)

Attached patch v1Splinter Review
The actual coordinates should be wrong until bug 1075670 is fixed.
Attachment #8574072 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8574072 [details] [diff] [review]
v1

>+    if (!text || !text->IsTextRole()) {
>+      return;
>+    }
>+    rect = text->CharBounds(aOffset, geckoCoordType);

stuff on line after } still seems very weird to me.
Attachment #8574072 - Flags: review?(tbsaunde+mozbugs) → review+
Sorry, I'm trying to follow this a11y coding style, but missing occasionally.
Takes time to get used to it.
Attached patch v2 (+ newlines)Splinter Review
https://hg.mozilla.org/mozilla-central/rev/d5f0d1845ecc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.