Closed Bug 1140500 Opened 5 years ago Closed 5 years ago

add object attributes declaration into markup map

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: surkov, Assigned: surkov)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
AttrFromDOMIf is not used but should be nice for object attributes for input@type values
Attachment #8574073 - Flags: review?(mzehe)
Attachment #8574073 - Flags: review?(mzehe) → review+
https://hg.mozilla.org/mozilla-central/rev/d82de5d43ebc
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
It seems to me this is adding more complexity without helping anything.
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> It seems to me this is adding more complexity without helping anything.

it's about being more declarative and vivid, it gets us closer to add/remove/change markup mappings easily.
(In reply to alexander :surkov from comment #3)
> (In reply to Trevor Saunders (:tbsaunde) from comment #2)
> > It seems to me this is adding more complexity without helping anything.
> 
> it's about being more declarative and vivid, it gets us closer to
> add/remove/change markup mappings easily.

I'm unconvinced being declarative is a good thing, and I don't know what vivid means in context.
I meant you can see all role mappings for makrup in one place
(In reply to alexander :surkov from comment #5)
> I meant you can see all role mappings for makrup in one place

accept all the stuff you can't do declaratively, and even if you could that doesn't seem very useful especially when the price is its much harder to know what code does.
(In reply to Trevor Saunders (:tbsaunde) from comment #6)
> (In reply to alexander :surkov from comment #5)
> > I meant you can see all role mappings for makrup in one place
> 
> accept all the stuff you can't do declaratively, and even if you could that
> doesn't seem very useful especially when the price is its much harder to
> know what code does.

there's always trade-off, I think declarative component we've got is a good way to go which you're probably disagree with.
(In reply to alexander :surkov from comment #7)
> (In reply to Trevor Saunders (:tbsaunde) from comment #6)
> > (In reply to alexander :surkov from comment #5)
> > > I meant you can see all role mappings for makrup in one place
> > 
> > accept all the stuff you can't do declaratively, and even if you could that
> > doesn't seem very useful especially when the price is its much harder to
> > know what code does.
> 
> there's always trade-off, I think declarative component we've got is a good
> way to go which you're probably disagree with.

yeah, it makes things significantly worse than they were before.  It may be a trade but the gains seen pretty insignificant.
I heard you, thanks for sharing your opinion.
You need to log in before you can comment on or make changes to this bug.