Closed
Bug 1140500
Opened 9 years ago
Closed 9 years ago
add object attributes declaration into markup map
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: surkov, Assigned: surkov)
Details
Attachments
(1 file)
13.00 KB,
patch
|
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
AttrFromDOMIf is not used but should be nice for object attributes for input@type values
Attachment #8574073 -
Flags: review?(mzehe)
Updated•9 years ago
|
Attachment #8574073 -
Flags: review?(mzehe) → review+
Comment 1•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d82de5d43ebc
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment 2•9 years ago
|
||
It seems to me this is adding more complexity without helping anything.
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #2) > It seems to me this is adding more complexity without helping anything. it's about being more declarative and vivid, it gets us closer to add/remove/change markup mappings easily.
Comment 4•9 years ago
|
||
(In reply to alexander :surkov from comment #3) > (In reply to Trevor Saunders (:tbsaunde) from comment #2) > > It seems to me this is adding more complexity without helping anything. > > it's about being more declarative and vivid, it gets us closer to > add/remove/change markup mappings easily. I'm unconvinced being declarative is a good thing, and I don't know what vivid means in context.
Assignee | ||
Comment 5•9 years ago
|
||
I meant you can see all role mappings for makrup in one place
Comment 6•9 years ago
|
||
(In reply to alexander :surkov from comment #5) > I meant you can see all role mappings for makrup in one place accept all the stuff you can't do declaratively, and even if you could that doesn't seem very useful especially when the price is its much harder to know what code does.
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #6) > (In reply to alexander :surkov from comment #5) > > I meant you can see all role mappings for makrup in one place > > accept all the stuff you can't do declaratively, and even if you could that > doesn't seem very useful especially when the price is its much harder to > know what code does. there's always trade-off, I think declarative component we've got is a good way to go which you're probably disagree with.
Comment 8•9 years ago
|
||
(In reply to alexander :surkov from comment #7) > (In reply to Trevor Saunders (:tbsaunde) from comment #6) > > (In reply to alexander :surkov from comment #5) > > > I meant you can see all role mappings for makrup in one place > > > > accept all the stuff you can't do declaratively, and even if you could that > > doesn't seem very useful especially when the price is its much harder to > > know what code does. > > there's always trade-off, I think declarative component we've got is a good > way to go which you're probably disagree with. yeah, it makes things significantly worse than they were before. It may be a trade but the gains seen pretty insignificant.
Assignee | ||
Comment 9•9 years ago
|
||
I heard you, thanks for sharing your opinion.
You need to log in
before you can comment on or make changes to this bug.
Description
•