Closed Bug 1140516 Opened 11 years ago Closed 11 years ago

ingest_push doesn't work for pushes with more than one commit

Categories

(Tree Management :: Treeherder: Data Ingestion, defect, P2)

Product:
Tree Management
Component:
Treeherder: Data Ingestion
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

Details

Attachments

(1 file)

Fix ingest_push for pushes with more than one commit
54 bytes, text/x-github-pull-request
emorley
: review+
Details | Review
This is because the "topmost" commit of a push is the last commit in the json object returned by json-pushes, not the first. E.g.: https://hg.mozilla.org/integration/mozilla-inbound/json-pushes/?full=1&changeset=e2358ee2e4c8 It's changeset e2358ee2e4c8 that we want here (that's the push id identified in builds4hr), not 7a78ca49e38ef871. I believe this only effects that ingest_push subcommand. For the regular buildapi fetching, we would have been fetching from the wrong push id, but in my testing this doesn't seem to make a difference (we still get newer pushes just fine)
Summary: ingest_push doesn't work for commits with more than one commit → ingest_push doesn't work for pushes with more than one commit
Assignee: nobody → wlachance
Attachment #8574160 - Flags: review?(emorley)
Comment on attachment 8574160 [details] [review] Fix ingest_push for pushes with more than one commit Ha! oops...
Attachment #8574160 - Flags: review?(emorley) → review+
Status: NEW → ASSIGNED
OS: Linux → All
Priority: -- → P2
Hardware: x86_64 → All
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: