timeline should show asyncParent

RESOLVED FIXED in Firefox 39

Status

RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

({dev-doc-complete})

Trunk
Firefox 39
x86_64
Linux
dev-doc-complete
Bug Flags:
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Now that stack traces can have an asyncParent (see bug 1083359),
this information should be displayed on timeline markers as well.
(Assignee)

Updated

4 years ago
Assignee: nobody → ttromey
(Assignee)

Comment 1

4 years ago
Created attachment 8575433 [details] [diff] [review]
show async stacks attached to timeline markers

This arranges for async parents to be displayed in a timeline marker's
stack trace.  Right now these seem to be attached to promises, but
more could be added later.

I went back and forth on how to indicate that the parent frame is
async.  Right now I have it show "(Async: Cause)" as its own line in
the stack trace.  The "Cause" is the string supplied by the core.  For
promises, it is "Promise".
(Assignee)

Updated

4 years ago
Attachment #8575433 - Flags: review?(vporof)
Comment on attachment 8575433 [details] [diff] [review]
show async stacks attached to timeline markers

Review of attachment 8575433 [details] [diff] [review]:
-----------------------------------------------------------------

Cool
Attachment #8575433 - Flags: review?(vporof) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

4 years ago
I just remembered this will need a slight rebase once bug 1141553 goes in.
So removing checkin-needed for now.
Keywords: checkin-needed
(Assignee)

Comment 5

4 years ago
Created attachment 8576010 [details] [diff] [review]
show async stacks attached to timeline markers
Attachment #8575433 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/d3cf2d70afa5
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d3cf2d70afa5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Setting qe-verify- since this is already covered by automated testing. Tom, if you think there's something manual QA should look at here, please flip that flag.
Flags: qe-verify-
Keywords: dev-doc-needed
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
I've added something to the Waterfall page on this: https://developer.mozilla.org/en-US/docs/Tools/Performance/Waterfall#Async_stack. Does that cover it? It seems like this is new in Firefox 41 (I don't see it in Firefox 40), although this bug landed a while ago.
Flags: needinfo?(ttromey)
(Assignee)

Comment 11

3 years ago
(In reply to Will Bamberg [:wbamberg] from comment #10)
> I've added something to the Waterfall page on this:
> https://developer.mozilla.org/en-US/docs/Tools/Performance/
> Waterfall#Async_stack. Does that cover it? It seems like this is new in
> Firefox 41 (I don't see it in Firefox 40), although this bug landed a while
> ago.

I don't know what version it first worked in.

This looks good to me.  One minor thing is that, while right now we only
have async stacks for Promises, at some point there will be async stacks
for many more things.  See bug 1148593.  Also, there has been some discussion
of preffing off async stacks due to performance issues; there are some bugs
open about this as well.
Flags: needinfo?(ttromey)
Keywords: dev-doc-needed → dev-doc-complete

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.