Closed Bug 11406 Opened 20 years ago Closed 17 years ago
[FONT MAC]Mac GFX doesn't handle NS
_FONT _DECORATION _OVERLINE or NS _FONT _DECORATION _LINE _THROUGH
Mac GFX doesn't handle NS_FONT_DECORATION_OVERLINE or NS_FONT_DECORATION_LINE_THROUGH in nsFontMetricsMac.cpp. Right now they just underline, which is not right, but i wanted to get the cases in there for completeness.
Summary: Mac GFX doesn't handle NS_FONT_DECORATION_OVERLINE or NS_FONT_DECORATION_LINE_THROUGH → [FONT MAC]Mac GFX doesn't handle NS_FONT_DECORATION_OVERLINE or NS_FONT_DECORATION_LINE_THROUGH
This bug has been marked future because we have determined that it is not critical for netscape 6.0. If you feel this is an error, or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.
Target Milestone: M17 → Future
Does this bug mean that on Mac, we don't support 'text-decoration:overline' and 'text-decoration:line-through' ?
Well, for lack of a response, and lack of a Mac, I'll assume it does and nominate it for nsbeta3, since it's a basic css1 issue and platform parity.
This has to be disscussed,,, not just moved to Beta 3..
Target Milestone: --- → Future
this has to be discussed, not just moved to future...
The decorations are handled in nsTextFrame::PaintTextDecorations(). Overline and line-through work correctly on the Mac, as you can see when displaying Test0. Pink, why did you add the 4 lines with the comment "THIS IS WRONG, BUT HERE FOR COMPLETENESS" in nsFontMetricsMac? Maybe we can remove them and close the bug as Invalid.
i wanted to get the cases in there so there was something to hang the correct code on when it was written, but underline is obviously the wrong style for overline and line-through, hence the comment.
Got it. I confirm that this bug can be left as Future because of the way we draw text in Layout. We cache a font without decorations ("mNormalFont" with NS_FONT_DECORATION_NONE) and we draw the decorations ourselves without using GFX.
if this works as pierre says (which would be a good thing), then we should remove the relnote2 keyword. anyone?
If it's working then removing relnote2 makes sense. I really don't understand what's left in this bug. Does it deserve the arch keyword?
Changing keywords from "css1, fonts, nsbeta3, pp, relnote2, verifyme" to "fonts, pp"
Can someone please put this bug out of its misery with a FIXED, INVALID or WONTFIX to the head?
Fixing it is, of course, preferable. Don?
The relevant code has moved to nsFontUtils. But the question remains -- is this a problem?
Assignee: dcone → sfraser
Status: ASSIGNED → NEW
Patch to remove setting underline/linethrough types in the native font style. This is all handled by nsTextFrame: http://lxr.mozilla.org/seamonkey/source/layout/html/base/src/nsTextFrame.cpp#1846
Comment on attachment 115812 [details] [diff] [review] Patch to remove bogus code from nsFontUtils r=smontagu
Attachment #115812 - Flags: review?(smontagu) → review+
Comment on attachment 115812 [details] [diff] [review] Patch to remove bogus code from nsFontUtils firstname.lastname@example.org
Attachment #115812 - Flags: superreview?(kin) → superreview+
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.