Closed
Bug 1140636
Opened 9 years ago
Closed 6 years ago
CPOWs don't maintain identity for toString
Categories
(Core :: DOM: Content Processes, defect, P3)
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: mrbkap, Unassigned)
Details
Attachments
(1 file)
1.51 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Given a CPOW cpow, |cpow.toString !== cpow.toString|. This isn't an important bug, and patching it would be annoying (we'd need a "holder" object as a second private value on each CPOW, which IMO wouldn't be worth it). But I figured that it'd be useful at least having a bug on this.
Reporter | ||
Comment 1•9 years ago
|
||
Here's a test that we can check in sooner rather than later.
Attachment #8574208 -
Flags: review?(wmccloskey)
Attachment #8574208 -
Flags: review?(wmccloskey) → review+
Reporter | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=48ca686b782b
Reporter | ||
Updated•9 years ago
|
Keywords: checkin-needed,
leave-open
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce40549140ab
Keywords: checkin-needed
Comment 4•9 years ago
|
||
This only a test, a fix is still needed here. Triage still needed.
Updated•9 years ago
|
Updated•8 years ago
|
Priority: -- → P3
Comment 6•6 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months. :jimm, maybe it's time to close this bug?
Flags: needinfo?(jmathies)
Comment 7•6 years ago
|
||
CPOWs are deprecated, and if I recall correctly the last status update about removing them said that we no longer call methods or access properties on them. So this is probably WONTFIX, but someone who's actually involved with CPOW removal should confirm.
Comment 8•6 years ago
|
||
(In reply to Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧ from comment #7) > CPOWs are deprecated, and if I recall correctly the last status update about > removing them said that we no longer call methods or access properties on > them. So this is probably WONTFIX, but someone who's actually involved with > CPOW removal should confirm. which is not me. I think felipe might know more about this.
Flags: needinfo?(jmathies) → needinfo?(felipc)
Comment 9•6 years ago
|
||
Yeah, CPOWs are deprecated and only used in tests now. Given this, and that this bug is not too important (as mentioned in comment 0), let's WONTFIX it
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(felipc)
Keywords: leave-open
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•