Closed Bug 1140673 Opened 5 years ago Closed 5 years ago

[Hacker Marketplace] Visual improvments after review.

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mikehenrty, Unassigned)

References

()

Details

(Whiteboard: [spark])

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1133976#c6.

This bug aims to fix:
> 2. Homescreen: The font for the tabs “Apps” and “Add-ons” should be Fira
> Sans Italic. It looks like Light Italic right now.

> 3. Homescreen: Can you reduce the size of the “upload” icon by 83% ? 

> 7. App/Add-On screen: When you press install and the install is complete,
> the button should change to “open”, the same way as when you install from
> the homescreen.
Attached file [PR] update visuals
Looks like the header was indeed using FiraSans.

Doug, wanna have a look?
Attachment #8574242 - Flags: review?(drs.bugzilla)
Comment on attachment 8574242 [details] [review]
[PR] update visuals

Looks good, but I left a comment about using 'install' and 'uninstall' events instead of 'visibilitychange' to detect app installs/uninstalls. You could fix that here or elsewhere.
Attachment #8574242 - Flags: review?(drs.bugzilla) → review+
master: https://github.com/fxos/directory/commit/12a2efce16df139369b42c5c85da23f95287c41d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
You need to log in before you can comment on or make changes to this bug.