1140674 - Remove extra LinearLayout view in doorhanger

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Bug 1137921 introduces a shadow 9-patch, but in anchored_popup_bg, mcomella suggests removing the extra parent view [1]. We can do this, but because the corners become unrounded, it needs to be replaced with a layer-list that has the dropshadow, and then a doorhanger <shape> with rounded corners [2]. The child views should then be set to color:transparent.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1137921#c17
[2] http://stackoverflow.com/questions/21000041/it-is-possible-to-use-a-shape-drawables-for-round-corners-and-a-9-patch-image-fo

Comment 1

[Justin Inouye [:inouju]]

I had a question on this bug since I was working on the anchored_popup.xml from Bug 1146735. 

Since we are now using a RoundedCornerLayout, wouldn't it be safe to remove the extra parent view without the need for a layer-list?

Comment 2

[Chenxia Liu [:liuche]]

No, we still need to have two layered views, one for shadow and one for the popup. RoundedCornerLayout doesn't take into account the shadow, which it would only be able to do if the background was actually a 9-patch image (but we removed that because hand-maintaining a shadow is much more annoying). One thing that I was considering, however, was replacing the whole thing with CardView from the support library, which handles the shadow, rounded corners, and also anchoring/positioning for long doorhangers (bug 1180597).

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

liuche, still relevant? I can't find anchored_popup_bg:
  http://mxr.mozilla.org/mozilla-central/find?text=&string=anchored_popup_bg