Closed Bug 1140716 Opened 10 years ago Closed 10 years ago

Uploading a version source file with a two dotted extension (like .tar.gz) breaks filename extension

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Product:
addons.mozilla.org Graveyard
Component:
Developer Pages
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2015-04

People

(Reporter: TheOne, Assigned: TheOne)

Details

(Whiteboard: [ReviewTeam])

If a user uploads a version source with the filename 'logo.tar.gz' for example, the file is stored and served as 'logo.tar_zvDuOFa.gz', thus breaking the extension.
Assignee: nobody → mail
This PR renames uploaded source files to "<addon-name>-<version>-src.<ext>" which 1) gives them a meaningful name, 2) keeps the extension intact.
Fixed in https://github.com/mozilla/olympia/commit/a65f49cfce5c1c18032a39e7b34336e9783f241e Thanks Andreas!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-04
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.