Closed Bug 1140762 Opened 5 years ago Closed 5 years ago

Move TestThreads.cpp to gtest and enable it

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

No description provided.
Attachment #8574338 - Flags: review?(nfroyd)
Assignee: nobody → ehsan
Comment on attachment 8574338 [details] [diff] [review]
Move TestThreads.cpp to gtest and enable it

Review of attachment 8574338 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/tests/gtest/TestThreads.cpp
@@ +86,4 @@
>      }
>  
>  protected:
>      static int32_t gNum;

Can you file a followup for this to make it Atomic?

@@ +103,5 @@
>      for (int i = 0; i < loops; i++) {
>          printf("Loop %d of %d\n", i+1, loops);
>  
>          int k;
>          nsIThread** array = new nsIThread*[threads];

Can you file a followup for making this UniquePtr<nsIThread*[]>?  (Not sure this will work, given the requirement to use NS_NewThread...)

@@ +142,1 @@
>          PRThread** array = new PRThread*[threads];

Can you file a followup for making this UniquePtr<PRThread*[]>?
Attachment #8574338 - Flags: review?(nfroyd) → review+
Filed bug 1141115 and bug 1141116 as follow-ups.
https://hg.mozilla.org/mozilla-central/rev/880f9ec36cfe
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.