Closed Bug 1140764 Opened 6 years ago Closed 6 years ago

"suggested reviewers" menu overflows from visible area if there are many reviewers.

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(2 files)

In Core/JavaScript Engine Component, there are 21 reviewers, and if I open "suggested reviewers" without scrolling from top of the page, it overflows, and I have to scroll down until the menu is shown under the anchor.
  https://bugzilla.mozilla.org/attachment.cgi?bugid=1005110&action=enter

Also, in Core/DOM: Core & HTML Component, the menu overflows horizontally if I click around "u" in "suggested reviewers".
  https://bugzilla.mozilla.org/attachment.cgi?bugid=949971&action=enter

The top-left corner of the menu shouldn't be outside of client area.
Blocks: 1129283
Component: User Interface → Extensions: Review
No longer blocks: 1129283
Depends on: 1129283
Vertical overflow is fixed by following changeset in upstream trunk, but not yet released:
https://github.com/medialize/jQuery-contextMenu/commit/86948516b99ef0bb8b8a3f1fdd6c536f2ec548a1

Horizontal overflow is not yet fixed in upstream.

For now, this could be fixed in our side. with just one liner patch, but it should be better to fix also in upstream, and pull on next release.
Attachment #8574973 - Flags: review?(dkl)
Comment on attachment 8574973 [details] [diff] [review]
Prevent suggested reviewers menu from overflowing from client area.

Review of attachment 8574973 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks. r=dkl
Attachment #8574973 - Flags: review?(dkl) → review+
Assignee: nobody → arai.unmht
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   5b9f16e..19643ae  master -> master
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Summary: "suggested reviewers" menu overflows from visible area if there are many revirewers. → "suggested reviewers" menu overflows from visible area if there are many reviewers.
See Also: → 1213791
Component: Extensions: Review → Extensions
You need to log in before you can comment on or make changes to this bug.