1140764 - "suggested reviewers" menu overflows from visible area if there are many reviewers.

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Tooru Fujisawa [:arai]]

Attachment: suggested_reviewers_overflow.png

In Core/JavaScript Engine Component, there are 21 reviewers, and if I open "suggested reviewers" without scrolling from top of the page, it overflows, and I have to scroll down until the menu is shown under the anchor.
  https://bugzilla.mozilla.org/attachment.cgi?bugid=1005110&action=enter

Also, in Core/DOM: Core & HTML Component, the menu overflows horizontally if I click around "u" in "suggested reviewers".
  https://bugzilla.mozilla.org/attachment.cgi?bugid=949971&action=enter

The top-left corner of the menu shouldn't be outside of client area.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Prevent suggested reviewers menu from overflowing from client area.

Vertical overflow is fixed by following changeset in upstream trunk, but not yet released:
https://github.com/medialize/jQuery-contextMenu/commit/86948516b99ef0bb8b8a3f1fdd6c536f2ec548a1

Horizontal overflow is not yet fixed in upstream.

For now, this could be fixed in our side. with just one liner patch, but it should be better to fix also in upstream, and pull on next release.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8574973 [details] [diff] [review]
Prevent suggested reviewers menu from overflowing from client area.

Review of attachment 8574973 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks. r=dkl

Comment 3

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   5b9f16e..19643ae  master -> master