1140808 - Fennec debug build crashes on app-switch due to hashtable reinitialization

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Crash stack

I did a debug build of Fennec using latest m-c code and installed it on a Nexus 4 running Android 4.2.2. Upon startup I hit the crash reported in bug 1140806, so I commented out the assertion referenced there which allowed Fennec to start up. Once Fennec starts up, hit the Android app-switch button, and from the app chooser go back into Fennec. At this point Fennec crashes with the attached stack which seems to point to a hashtable reinitialization in nsCacheService.cpp

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8575553 [details] [diff] [review]
Patch

Honza appears to be away or something.

Comment 3

[Patrick McManus [:mcmanus]]

Comment on attachment 8575553 [details] [diff] [review]
Patch

Review of attachment 8575553 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm but I'd feel better if someone working on the cache code reviewed it. michal?

Comment 4

[Michal Novotny [:michal]]

Comment on attachment 8575553 [details] [diff] [review]
Patch

Review of attachment 8575553 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/cache/nsCacheService.cpp
@@ +1208,5 @@
>              return;
>  
>          mClearingEntries = true;
>          DoomActiveEntries(nullptr);
> +        mActiveEntries.Shutdown();

AFAICS, some nsDoomEvent can be waiting for a lock on a background thread. nsDoomEvent::Run() calls mActiveEntries.GetEntry() which would assert. mActiveEntries.Shutdown() should be IMO moved after this line http://hg.mozilla.org/mozilla-central/annotate/008b3f65a7e0/netwerk/cache/nsCacheService.cpp#l1234

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

That works too.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54ab128ef1c0

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/54ab128ef1c0