1140820 - Hover over Speaker button doesn't trans cursor to pointer

Status: RESOLVED INCOMPLETE

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Mahir Labib Chowdhury]

User Agent: Mozilla/5.0 (Windows NT 6.3; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150227004023

Steps to reproduce:

1. Go to Popcorn Maker
2. Hover over the "Speaker/Mute" button ( placed left bottom, beside play/pause" 


Actual results:

The cursor became a "I-beam"


Expected results:

The cursor should be a pointer

Comment 1

[Mahir Labib Chowdhury]

Can you check on this?

Comment 2

[Scott [:thecount] Downe]

It's still an issue.

Comment 3

[Imogen Wentworth [:negomi]]

Hi, could I take this bug?

Comment 4

[Imogen Wentworth [:negomi]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/600

Comment 5

[Imogen Wentworth [:negomi]]

^ Pasted that attachment on the wrong bug, sorry!

Comment 6

[Matthew Schranz [:mjschranz]]

Comment on attachment 8586975 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/600

This is really great and works well but after seeing the completed solution I have one thing I would like to add.

Seeing that now the key "Click to remove warning" contains only HTML that is to be rendered could we just remove that key and have the HTML for the button be static in the layout file (warn.html)?

Thanks!

Comment 7

[Matthew Schranz [:mjschranz]]

Comment on attachment 8586975 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/600

Haha woops! I just noticed that myself. I'll reset all of this for you and move my comments over to there.

Just goes to show how little I have used Bugzilla lately!

Comment 8

[Imogen Wentworth [:negomi]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/601

Comment 9

[Matthew Schranz [:mjschranz]]

Comment on attachment 8586988 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/601

R+!

Thanks for the patch :)

Comment 10

[Matthew Schranz [:mjschranz]]

Looks like I have lost my commit access to the Github repo Scott. Mind landing this patch?

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/6a9303e3aeeddfc491601f1aa7c0063d649abadf
Bug 1140820 - Show pointer when hovering over mute button

https://github.com/mozilla/popcorn.webmaker.org/commit/049036ddb9f330cb311a3cd726015ef55956911a
Merge pull request #601 from negomi/bug1140820

Bug 1140820 - Show pointer when hovering over mute button

Comment 12

[Chris DeCairos (:cade)]

Popcorn Maker is no longer under active development.

https://learning.mozilla.org/blog/product-update-for-appmaker-and-popcorn-maker