Last Comment Bug 1140840 - Icon for New Event/Task in Write button drop down menu do not match Lightning theme
: Icon for New Event/Task in Write button drop down menu do not match Lightning...
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Lightning Only (show other bugs)
: Lightning 4.0.0.1
: x86_64 Windows 7
-- trivial (vote)
: 4.0.0.1
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-08 06:10 PDT by Stefan Sitter
Modified: 2015-03-12 08:25 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
icons.png (18.84 KB, image/png)
2015-03-08 06:10 PDT, Stefan Sitter
no flags Details
b1140840.patch (2.11 KB, patch)
2015-03-08 07:48 PDT, Richard Marti (:Paenglab)
philipp: review+
philipp: approval‑calendar‑aurora+
Details | Diff | Splinter Review

Description User image Stefan Sitter 2015-03-08 06:10:09 PDT
Created attachment 8574387 [details]
icons.png

Lightning 4.0a2 (BuildID 20150307004252) with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0a2

The icons for 'New Event' and 'New Task' in the 'Write' button drop down menu do not match the remaining Thunderbird and Lightning theme, see attached screenshot. In my opinion the same icon as shown e.g. in the calendar tabs should be used.
Comment 1 User image Richard Marti (:Paenglab) 2015-03-08 07:48:38 PDT
Created attachment 8574401 [details] [diff] [review]
b1140840.patch

Yes, this matches better.

Philipp, do we want this for 4.0?
Comment 2 User image Philipp Kewisch [:Fallen] 2015-03-08 08:22:11 PDT
Comment on attachment 8574401 [details] [diff] [review]
b1140840.patch

Review of attachment 8574401 [details] [diff] [review]:
-----------------------------------------------------------------

ok for Lightning 4.0 r/a=philipp
Comment 3 User image Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) 2015-03-10 06:44:53 PDT
https://hg.mozilla.org/comm-central/rev/cb001bea2787
Comment 4 User image Richard Marti (:Paenglab) 2015-03-12 08:25:45 PDT
https://hg.mozilla.org/releases/comm-aurora/rev/545f15e719f2

Note You need to log in before you can comment on or make changes to this bug.