Closed
Bug 1140862
Opened 9 years ago
Closed 9 years ago
multi_day_test.js | Views.MultiDay localized - display hour: expected '\n 3\n ' to equal 2 on Spring DST change day
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(b2g-v2.1 affected, b2g-v2.1S affected, b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S8 (20mar)
People
(Reporter: philor, Assigned: mmedeiros)
Details
(Keywords: intermittent-failure, Whiteboard: orange:time-bomb)
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
gaye
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
If you're going to look for an event to be active during the 02:00 hour, you're not going to have a good time on a day which does not have an 02:00 hour.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Updated•9 years ago
|
status-b2g-v2.1:
--- → affected
status-b2g-v2.1S:
--- → affected
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → affected
Reporter | ||
Updated•9 years ago
|
Keywords: intermittent-failure
Whiteboard: orange:time-bomb
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 12•9 years ago
|
||
Nice one. Calendar is not lucky those days. After bug 1128483, here come this one.
Updated•9 years ago
|
Flags: needinfo?(mmedeiros)
Flags: needinfo?(gaye)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 34•9 years ago
|
||
Yeah, we hit this for the "last day of month" bug also. We really need to mock all dates that we use in calendar tests...
Comment 35•9 years ago
|
||
Yikes
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 37•9 years ago
|
||
in this case we should not mock the test date, we should really update the way we build the hours on the multi day views to make sure we always display 24h (even if first day of DST).
Assignee: nobody → mmedeiros
Flags: needinfo?(mmedeiros)
Flags: needinfo?(gaye)
Assignee | ||
Comment 38•9 years ago
|
||
just to be clear, this test catched a real bug. on the first day of DST the sidebar displays `3AM` twice. I'm going to provide a patch soon.
Status: NEW → ASSIGNED
Comment 39•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8575440 -
Flags: review?(gaye)
Updated•9 years ago
|
Attachment #8575440 -
Flags: review?(gaye) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 40•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/5c581041bc90c89a90bb8c49d6291b7880a3f04a
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 41•9 years ago
|
||
Comment on attachment 8575440 [details] [review] [gaia] millermedeiros:1140862-multi-day-test-dst > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): none [User impact] if declined: during the daylight time change in some countries user might see the wrong hours displayed on the sidebar (same hour showed twice) [Testing completed]: manual and unit [Risk to taking this patch] (and alternatives if risky): very low [String changes made]: none
Attachment #8575440 -
Flags: approval-gaia-v2.2?
Updated•9 years ago
|
Attachment #8575440 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 42•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/3df30482f2d59a45fe0d67d31e6bd3781cc2cda3
Target Milestone: --- → 2.2 S8 (20mar)
You need to log in
before you can comment on or make changes to this bug.
Description
•