Closed Bug 1140862 Opened 9 years ago Closed 9 years ago

multi_day_test.js | Views.MultiDay localized - display hour: expected '\n 3\n ' to equal 2 on Spring DST change day

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.1 affected, b2g-v2.1S affected, b2g-v2.2 fixed, b2g-master fixed)

RESOLVED FIXED
2.2 S8 (20mar)
Tracking Status
b2g-v2.1 --- affected
b2g-v2.1S --- affected
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: philor, Assigned: mmedeiros)

Details

(Keywords: intermittent-failure, Whiteboard: orange:time-bomb)

Attachments

(1 file)

If you're going to look for an event to be active during the 02:00 hour, you're not going to have a good time on a day which does not have an 02:00 hour.
Whiteboard: orange:time-bomb
Nice one. Calendar is not lucky those days. After bug 1128483, here come this one.
Flags: needinfo?(mmedeiros)
Flags: needinfo?(gaye)
Yeah, we hit this for the "last day of month" bug also. We really need to mock all dates that we use in calendar tests...
in this case we should not mock the test date, we should really update the way we build the hours on the multi day views to make sure we always display 24h (even if first day of DST).
Assignee: nobody → mmedeiros
Flags: needinfo?(mmedeiros)
Flags: needinfo?(gaye)
just to be clear, this test catched a real bug. on the first day of DST the sidebar displays `3AM` twice. I'm going to provide a patch soon.
Status: NEW → ASSIGNED
Attachment #8575440 - Flags: review?(gaye)
Attachment #8575440 - Flags: review?(gaye) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8575440 [details] [review]
[gaia] millermedeiros:1140862-multi-day-test-dst > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: during the daylight time change in some countries user might see the wrong hours displayed on the sidebar (same hour showed twice)
[Testing completed]: manual and unit
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none
Attachment #8575440 - Flags: approval-gaia-v2.2?
Attachment #8575440 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: