Closed
Bug 1140955
Opened 9 years ago
Closed 9 years ago
[Stingray][Component] Move smart-button to gaia-components repository
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rexboy, Assigned: rexboy)
References
Details
(Whiteboard: [partner-cherry-picked<2015/11/10>])
Attachments
(2 files)
We are going to move smart-button component: https://github.com/smart-components/smart-button to gaia-components. I think what we need to do are: 1. open a smart-button repo in gaia-components; 2. Review and check-in smart-button there (Pull request 1: to gaia-components/smart-button); 3. Make apps that is using smart-button point to gaia-components (Pull request 2: to gaia).
Assignee | ||
Updated•9 years ago
|
Blocks: tv-gaia-components
Assignee | ||
Comment 1•9 years ago
|
||
This is the patch for gaia-component part. After landing we would need to update gaia side to use this repository. John would you help review this bug?
Attachment #8576603 -
Flags: review?(im)
Comment 2•9 years ago
|
||
Comment on attachment 8576603 [details] [review] Patch to gaia-components Looks good to me.
Attachment #8576603 -
Flags: review?(im) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Commit for gaia-components: https://github.com/gaia-components/smart-button/commit/a13686c5620b996e254764eb9b6993c9555da862 And let's patch Gaia master. I think put them both in this patch should be more clear so let's just do it in this patch.
Assignee | ||
Comment 4•9 years ago
|
||
Tzu-lin: this is Gaia side patch (1 of 3 commits in a pull request) may you help review this bug?
Attachment #8577124 -
Flags: review?(tzhuang)
Comment 5•9 years ago
|
||
Comment on attachment 8577124 [details] [review] patch Looks good to me. Thanks
Attachment #8577124 -
Flags: review?(tzhuang) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/27853329e91ea665110df75bda4f968606d66275
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
Updated•9 years ago
|
Assignee: nobody → rexboy
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick] → [partner-cherry-picked<2015/11/10>]
You need to log in
before you can comment on or make changes to this bug.
Description
•