Closed Bug 1140957 Opened 7 years ago Closed 7 years ago
[Stingray][Component] Move smart-banner to gaia-components repository
We are going to move smart-button component: https://github.com/smart-components/smart-banner to gaia-components. I think what we need to do are: 1. open a smart-button repo in gaia-components; 2. Review and check-in smart-button there (Pull request 1: to gaia-components/smart-banner); 3. Make apps that is using smart-button point to gaia-components (Pull request 2: to gaia).
Sorry, several typo up there in Description :-/ please replace all `smart-button` to `smart-banner`.
https://github.com/gaia-components/smart-banner I've pushed smart-components/smart-banner to gaia-components/smart-banner Now we need to modify bower.json, add readme, and review them.
This is the patch for gaia-component part. After landing we would need to update gaia side to use this repository. Tzu-lin would you help review this bug?
Attachment #8576600 - Flags: review?(tzhuang)
Comment on attachment 8576600 [details] [review] Patch to gaia-components Looks good to me, thanks
Attachment #8576600 - Flags: review?(tzhuang) → review+
Commit for gaia-components: https://github.com/gaia-components/smart-banner/commit/01f885eced4ebe6e601bd252b2b5730309960b90 And let's patch Gaia master. I think put them both in this patch should be more clear so let's just do it in this patch.
Tzu-lin: this is Gaia side patch (1 of 3 commits in a pull request) may you help review this bug?
Attachment #8577121 - Flags: review?(tzhuang)
Comment on attachment 8577121 [details] [review] patch Looks good to me. Thanks
Attachment #8577121 - Flags: review?(tzhuang) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.