1140957 - [Stingray][Component] Move smart-banner to gaia-components repository

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We are going to move smart-button component:
https://github.com/smart-components/smart-banner
to gaia-components.

I think what we need to do are:
1. open a smart-button repo in gaia-components;
2. Review and check-in smart-button there
   (Pull request 1: to gaia-components/smart-banner);
3. Make apps that is using smart-button point to gaia-components
   (Pull request 2: to gaia).

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Sorry, several typo up there in Description :-/
please replace all `smart-button` to `smart-banner`.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/gaia-components/smart-banner
I've pushed smart-components/smart-banner to gaia-components/smart-banner

Now we need to modify bower.json, add readme, and review them.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch to gaia-components

This is the patch for gaia-component part.
After landing we would need to update gaia side to use this repository.

Tzu-lin would you help review this bug?

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8576600 [details] [review]
Patch to gaia-components

Looks good to me, thanks

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Commit for gaia-components:
https://github.com/gaia-components/smart-banner/commit/01f885eced4ebe6e601bd252b2b5730309960b90

And let's patch Gaia master.
I think put them both in this patch should be more clear so let's just do it in this patch.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Tzu-lin: this is Gaia side patch (1 of 3 commits in a pull request)
may you help review this bug?

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8577121 [details] [review]
patch

Looks good to me. Thanks

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/mozilla-b2g/gaia/commit/f96068af02f34df13582959ef88511eb624124fd