[Stingray][Component] Move menu-group to gaia-components repository

RESOLVED FIXED

Status

Firefox OS
Gaia::TV
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rexboy, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #1140958 +++

We are going to move menu-group component:
https://github.com/smart-components/menu-group
to gaia-components.

I think what we need to do are:
1. open a menu-group repo in gaia-components;
2. Review and check-in menu-group there
   (Pull request 1: to gaia-components/menu-group);
3. Make apps that is using menu-group point to gaia-components
   (Pull request 2: to gaia).
Blocks: 1140973
https://github.com/gaia-components/menu-group
I've pushed smart-components/menu-group to gaia-components/menu-group.

Now we need to modify bower.json, add readme, and review them.
Created attachment 8576570 [details] [review]
patch for gaia-components

This is patch for gaia-components repository.
After it got updated we need to update for Gaia repository too.

Tzu-lin may you help review this patch?
Attachment #8576570 - Flags: review?(tzhuang)
Comment on attachment 8576570 [details] [review]
patch for gaia-components

Looks good to me, thanks
Attachment #8576570 - Flags: review?(tzhuang) → review+
Commit for gaia-components:
https://github.com/gaia-components/menu-group/commit/088b750c3fd32c898f2fc30125a41f59eaee1257

And let's patch Gaia master.
I think put them both in this patch should be more clear so let's just do it in this patch.
Created attachment 8577122 [details] [review]
patch

Tzu-lin: this is Gaia side patch (1 of 3 commits in a pull request)
may you help review this bug?
Attachment #8577122 - Flags: review?(tzhuang)
Comment on attachment 8577122 [details] [review]
patch

Looks good to me. Thanks
Attachment #8577122 - Flags: review?(tzhuang) → review+
https://github.com/mozilla-b2g/gaia/commit/b093db8f38f119a95301c74d9b57fe7918247363
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Blocks: 1144539

Updated

3 years ago
Blocks: 1218722

Updated

3 years ago
No longer blocks: 1218722

Updated

3 years ago
Blocks: 1219540

Updated

3 years ago
No longer blocks: 1219540
You need to log in before you can comment on or make changes to this bug.