1140991 - [System] style/pinlock is not used any more

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Fabien Cazenave [:kaze]]

Grepping `pinlock.css` in the whole apps/ directory gives no result, except an entry in apps/system/manifest.appcache. Should we get rid of this stylesheet?

Comment 1

[Kevin Grandon :kgrandon]

(In reply to Fabien Cazenave [:kaze] from comment #0)
> Grepping `pinlock.css` in the whole apps/ directory gives no result, except
> an entry in apps/system/manifest.appcache. Should we get rid of this
> stylesheet?

Yes, I think we should remove it. It seems that manifest.appcache is no longer in the tree, and used to be possibly generated. It seems like just deleting the file should be fine.

Originally implemented here (before bugs existed): https://github.com/mozilla-b2g/gaia/commit/2aabf469505d6c0057d5dd1e7be68a27f6d1d341

Comment 2

[Kevin Grandon :kgrandon]

Guess I'll just take it since I was flagged.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1140991_remove_unused_simlock_css > mozilla-b2g:master

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8575530 [details] [review]
[gaia] KevinGrandon:bug_1140991_remove_unused_simlock_css > mozilla-b2g:master

Alex or Kaze - it seems that you guys have both done work here in the past, could one of you review this? Thanks!

Comment 5

[:gerard-majax]

Comment on attachment 8575530 [details] [review]
[gaia] KevinGrandon:bug_1140991_remove_unused_simlock_css > mozilla-b2g:master

That's with a lot of saddness that I'm giving you r+ for killing one of my very first contribution to B2G :)

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8575530 [details] [review]
[gaia] KevinGrandon:bug_1140991_remove_unused_simlock_css > mozilla-b2g:master

(In reply to Alexandre LISSY :gerard-majax from comment #5)
> That's with a lot of saddness that I'm giving you r+ for killing one of my
> very first contribution to B2G :)

It's ok, I'm sure your code has moved onto a better place now, and will forever be remembered.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/5d8deec4bbfcb71b542ad2a24d86dcd8e8b3ba4e