Closed Bug 1141016 Opened 9 years ago Closed 9 years ago

Use syncBrandShortName in ReadingList/Sync promo strings

Categories

(Firefox Graveyard :: Reading List, defect, P1)

Product:
Firefox Graveyard
Component:
Reading List
Type:
defect

Tracking

(firefox38 fixed, firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: Unfocused, Assigned: Unfocused)

References

(Blocks 1 open bug)

Details

(Whiteboard: [strings])

Attachments

(1 file, 1 obsolete file)

Patch v1.1
2.00 KB, patch
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
*sigh* So bug 1133673 pre-landed a bunch of strings for the ReadingList. A couple of these were for Sync promotion, and regrettably used a literal "Sync" instead of letting brandShortName be substituted in. That needs fixed.
Assignee: nobody → bmcbride
Status: UNCONFIRMED → ASSIGNED
Points: --- → 1
Ever confirmed: true
Flags: qe-verify-
Flags: firefox-backlog+
Priority: -- → P1
Attached patch Patch v1 (obsolete) — — Splinter Review 
This fixed up the strings needed for bug 1133610 & bug 1133611. We're still in the l10n hold period thankfully, so there's no worry about changing these strings.
Attachment #8574617 - Flags: review?(mhammond)
Blocks: 1132074
Iteration: --- → 39.1 - 9 Mar
Comment on attachment 8574617 [details] [diff] [review]
Patch v1

Review of attachment 8574617 [details] [diff] [review]:
-----------------------------------------------------------------

I'm surprised that matters (ie, that the brand names will ever not be "Sync") but whatever :)
Attachment #8574617 - Flags: review?(mhammond) → review+
Attached patch Patch v1.1 — — Splinter Review 
https://hg.mozilla.org/integration/fx-team/rev/9c9811d13276

Pre-landing more strings for the ReadingList project (I'm assuming we don't currently have blanket approval for Aurora).
Attachment #8574617 - Attachment is obsolete: true
Attachment #8575139 - Flags: approval-mozilla-aurora?
(This is intended to be landed after bug 1138738)
Iteration: 39.1 - 9 Mar → 39.2 - 23 Mar
https://hg.mozilla.org/mozilla-central/rev/9c9811d13276
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
It doesn't matter if Aurora it's not string frozen yet. Next time you update a string already landed in mozilla-central, just make sure you update the string ID.

Since the entire thing is already a mess and we need to move this stuff to Aurora, I won't ask you to fix this, but please let's not do it again.
"$S" should be changed to "%S" also in l10n notes…
Attachment #8575139 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: