Status

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: rik, Assigned: rehan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=1 s=bu.2015.5 [blocker] [UI])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Page 36 of v1.3 document.

Updated

4 years ago
Whiteboard: p=1 [blocker] → p=1 [blocker] [UI]

Updated

4 years ago
Whiteboard: p=1 [blocker] [UI] → p=1 s=bu.2015.5 [blocker] [UI]
(Reporter)

Updated

4 years ago
Summary: Sign In design → Sign In buttons design
(Reporter)

Updated

4 years ago
Summary: Sign In buttons design → Sign In page design
(Assignee)

Updated

4 years ago
Assignee: nobody → rdalal
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

4 years ago
Comment on attachment 8585107 [details] [review]
https://github.com/mozilla/buddyup/pull/133

Good job on this. I just have issues with the error styling, it should be a bit more OOCSS-like.
Attachment #8585107 - Flags: review?(anthony) → review-
(Assignee)

Updated

4 years ago
Attachment #8585107 - Flags: review- → review?(anthony)
(Reporter)

Comment 3

4 years ago
Comment on attachment 8585107 [details] [review]
https://github.com/mozilla/buddyup/pull/133

Left a question about CSS file organisation.
Attachment #8585107 - Flags: review?(anthony)
(Assignee)

Updated

4 years ago
Attachment #8585107 - Flags: review?(anthony)
(Reporter)

Comment 4

4 years ago
Comment on attachment 8585107 [details] [review]
https://github.com/mozilla/buddyup/pull/133

r+ after moving .ErrorList--auth in error-list.css
Attachment #8585107 - Flags: review?(anthony) → review+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(hcondei)
Flags: needinfo?(fredy)
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Flags: needinfo?(fredy)

Updated

4 years ago
Flags: needinfo?(hcondei)
You need to log in before you can comment on or make changes to this bug.