1141026 - BroadcastChannel can unregister a feature when not registered.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: feature.patch

Comment 1

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc6bbab0a730

Comment 2

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b02f6e654f5c

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8574630 [details] [diff] [review]
feature.patch

Approval Request Comment
[Feature/regressing bug #]: 966439
[User impact if declined]: we can a wrong behavior when a broadcast channel is created in a worker and that worker shutdowns immediately after.
[Describe test coverage new/current, TreeHerder]: it's a race condition. Hard to test with a mochitest
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Andrea Marchesini (:baku) from comment #3)
> [Feature/regressing bug #]: 966439

Bug 966439 landed in 38 (currently Aurora). Is this fix required in 37 Beta?

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b02f6e654f5c

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8574630 [details] [diff] [review]
feature.patch

No, beta is not needed.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/10c28009ec95