Closed Bug 1141032 Opened 5 years ago Closed 5 years ago

Debug: two minor fixes (related to JIT env and assert in irregexp)

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(2 files)

No description provided.
Attached patch 1.patchSplinter Review
Attachment #8574635 - Flags: review?(hv1989)
Attached patch 2.patchSplinter Review
Attachment #8574636 - Flags: review?(hv1989)
Comment on attachment 8574635 [details] [diff] [review]
1.patch

Review of attachment 8574635 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch
Attachment #8574635 - Flags: review?(hv1989) → review+
Comment on attachment 8574636 [details] [diff] [review]
2.patch

Review of attachment 8574636 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/JitOptions.cpp
@@ +43,5 @@
>      if (!str)
>          return dflt;
>      if (IsBool<T>::value) {
>          if (strcmp(str, "true") == 0 ||
> +            strcmp(str, "yes") == 0) {

can you put the two comparisons on one line?

or

put the { on a new line?

@@ +48,4 @@
>              return true;
>          }
>          if (strcmp(str, "false") == 0 ||
> +            strcmp(str, "no") == 0) {

ditto
Attachment #8574636 - Flags: review?(hv1989) → review+
You need to log in before you can comment on or make changes to this bug.