1141032 - Debug: two minor fixes (related to JIT env and assert in irregexp)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 1.patch

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 2.patch

Comment 3

[Hannes Verschore [:h4writer]]

Comment on attachment 8574635 [details] [diff] [review]
1.patch

Review of attachment 8574635 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch

Comment 4

[Hannes Verschore [:h4writer]]

Comment on attachment 8574636 [details] [diff] [review]
2.patch

Review of attachment 8574636 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/JitOptions.cpp
@@ +43,5 @@
>      if (!str)
>          return dflt;
>      if (IsBool<T>::value) {
>          if (strcmp(str, "true") == 0 ||
> +            strcmp(str, "yes") == 0) {

can you put the two comparisons on one line?

or

put the { on a new line?

@@ +48,4 @@
>              return true;
>          }
>          if (strcmp(str, "false") == 0 ||
> +            strcmp(str, "no") == 0) {

ditto

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

Thanks for the quick review!

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/003cb0664d29
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/48c981183ff3

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/003cb0664d29
https://hg.mozilla.org/mozilla-central/rev/48c981183ff3