Show user-friendly message when sharing a tab fails with error

RESOLVED WONTFIX

Status

Hello (Loop)
Client
P3
normal
Rank:
34
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: mikedeboer, Unassigned)

Tracking

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [string][errors])

(Reporter)

Description

3 years ago
Since bug 1141059, an error is passed to browser-switching listeners when an e10s tab is encountered.

We should display an nice error message that explains what's happening to the user.

Sevaan, could you create a mockup that shows how this should look like inside the conversation window?
Flags: qe-verify+
Flags: needinfo?(sfranks)
Flags: firefox-backlog+

Updated

3 years ago
Rank: 5
Priority: -- → P1
Whiteboard: [string][UX]

Comment 1

3 years ago
Hi Matej, 

I added you to this bug - since Sevaan will do "where it should be" and Matej is usually "what it should say".  This error will hopefully only be around for 2-3 releases for Firefox - as we will have Tabs working with e10s in 40 or 41.
Flags: needinfo?(matej)

Comment 2

3 years ago
(In reply to sescalante from comment #1)
> Hi Matej, 
> 
> I added you to this bug - since Sevaan will do "where it should be" and
> Matej is usually "what it should say".  This error will hopefully only be
> around for 2-3 releases for Firefox - as we will have Tabs working with e10s
> in 40 or 41.

Sounds good. Can you give me a little more context or direction for "what it should say"? Or should I wait for Sevaan's mockup and first pass?
Flags: needinfo?(matej)
Can you give me a little more information? I’m not sure I fully understand this.

What is a “browser switching listener”?
How is the error handled now?
Flags: needinfo?(sfranks)
(Reporter)

Comment 4

3 years ago
(In reply to Sevaan Franks [:sevaan] from comment #3)
> Can you give me a little more information? I’m not sure I fully understand
> this.
> 
> What is a “browser switching listener”?
> How is the error handled now?

Tab sharing follows the users' active tab along while navigating/ switching tabs. There are two types of error that might occur and we'd like to report back in the conversation window:

1. When tab sharing is initiated, there might be an error that there's no suitable tab open to share. This will happen when the conversation window is popped out and no other Fx windows are open or when only e10s tabs are available.
2. When the user switches to an e10s tab. This is not supported currently, but will be in the future.

Right now the error is ignored, since we don't have any means to display it.
Flags: needinfo?(sfranks)
> 1. When tab sharing is initiated, there might be an error that there's no
> suitable tab open to share. This will happen when the conversation window is
> popped out and no other Fx windows are open or when only e10s tabs are
> available.

For this case we should just pop the window back in to a new browser window. No need to display an error, let's just make it work for the user.

> 2. When the user switches to an e10s tab. This is not supported currently,
> but will be in the future.

Maybe we should we just hide the feature when E10s is enabled? Thoughts?
Flags: needinfo?(sfranks)

Comment 6

3 years ago
Mike will file a seperate bug for the
Rank: 5 → 30
Flags: needinfo?(mdeboer)
Priority: P1 → P3
Whiteboard: [string][UX] → [string][errors]
(Reporter)

Updated

3 years ago
Depends on: 1147442
(Reporter)

Updated

3 years ago
Flags: needinfo?(mdeboer)
Blocks: 1099241
No longer blocks: 1115336

Comment 7

3 years ago
e10s bugs will be fixed in 43... so production users won't see.  can re-open if making nightly users very sad.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Rank: 30 → 34
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.