Closed Bug 114116 Opened 23 years ago Closed 23 years ago

nsSegmentedBuffer::AppendNewSegment allocs 291 4096 byte buffers on startup

Categories

(Core :: XPCOM, defect, P3)

Product:
Core
Component:
XPCOM
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX
Milestone:
mozilla0.9.7

People

(Reporter: dp, Assigned: darin.moz)

Details

Attachments

(1 file)

test patch
8.11 KB, patch
Details | Diff | Splinter Review 
Totally about 1.1MB of 4k allocations happen here.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.7
i'm not measuring any real cost to these allocations.  on my linux box, i
reduced the amount of memory linux thinks i have down to 64M.  i tested a patch
that adds a cache of buffers 4096 bytes in size.  i varied the number of cached
buffers with an environment variable.  with different settings of this
environment variable, i noticed no measurable variation in startup time.

in other words, when it comes to 4k buffer allocations, i don't think you can
beat the system allocator.  of course, it'd be interesting to try this on windows.
Attached patch test patch — — Splinter Review 

    
    

    
  
I will try the patch on windows. 

    
    

    
  
looks like this patch isn't helping :(

marking WONTFIX
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: