Closed Bug 1141207 Opened 7 years ago Closed 6 years ago

GTK3 build fails undefined reference to `gtk_print_settings_foreach'

Categories

(Core :: Printing: Output, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: kbrosnan, Assigned: kbrosnan)

References

Details

Attachments

(1 file)

Looks like fallout from bug 1090448.

13:04.14 ../../widget/gtk/Unified_cpp_widget_gtk1.o: In function `nsPrintOptionsGTK::SerializeToPrintData(nsIPrintSettings*, nsIWebBrowserPrint*, mozilla::embedding::PrintData*)':
13:04.14 /home/kbrosnan/src/mc-clone/widget/gtk/nsPrintOptionsGTK.cpp:57: undefined reference to `gtk_print_settings_foreach'
13:04.14 collect2: error: ld returned 1 exit status
13:04.15 /home/kbrosnan/src/mc-clone/config/rules.mk:812: recipe for target 'libxul.so' failed
13:04.15 gmake[5]: *** [libxul.so] Error 1
Huh... strange. gtk_print_settings_foreach is apparently available for GTK3:

https://developer.gnome.org/gtk3/stable/GtkPrintSettings.html#gtk-print-settings-foreach

Or am I missing something here?
Add gtk_print_settings_foreach - builds successfully.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5751919a5042
Attachment #8574873 - Flags: review?(karlt)
Attachment #8574873 - Flags: review?(karlt) → review+
Try looks green.
Keywords: checkin-needed
You should do another try with this patch applied:
https://bugzilla.mozilla.org/attachment.cgi?id=8444892

(expect plenty of orange and red, but at least it should build)
(In reply to Kevin Brosnan [:kbrosnan] from comment #4)
> Try looks green.

so with comment 5 this needs another try run ?
Flags: needinfo?(kbrosnan)
Keywords: checkin-needed
You can land this, I verified it works.
Flags: needinfo?(kbrosnan)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5cb314c34f24
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.