Closed
Bug 1141207
Opened 9 years ago
Closed 9 years ago
GTK3 build fails undefined reference to `gtk_print_settings_foreach'
Categories
(Core :: Printing: Output, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: kbrosnan, Assigned: kbrosnan)
References
Details
Attachments
(1 file)
971 bytes,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
Looks like fallout from bug 1090448. 13:04.14 ../../widget/gtk/Unified_cpp_widget_gtk1.o: In function `nsPrintOptionsGTK::SerializeToPrintData(nsIPrintSettings*, nsIWebBrowserPrint*, mozilla::embedding::PrintData*)': 13:04.14 /home/kbrosnan/src/mc-clone/widget/gtk/nsPrintOptionsGTK.cpp:57: undefined reference to `gtk_print_settings_foreach' 13:04.14 collect2: error: ld returned 1 exit status 13:04.15 /home/kbrosnan/src/mc-clone/config/rules.mk:812: recipe for target 'libxul.so' failed 13:04.15 gmake[5]: *** [libxul.so] Error 1
Comment 1•9 years ago
|
||
Huh... strange. gtk_print_settings_foreach is apparently available for GTK3: https://developer.gnome.org/gtk3/stable/GtkPrintSettings.html#gtk-print-settings-foreach Or am I missing something here?
Comment 2•9 years ago
|
||
We need to an entry in http://hg.mozilla.org/mozilla-central/annotate/23f1f0369df5/widget/gtk/mozgtk/mozgtk.c
Assignee | ||
Comment 3•9 years ago
|
||
Add gtk_print_settings_foreach - builds successfully. https://treeherder.mozilla.org/#/jobs?repo=try&revision=5751919a5042
Attachment #8574873 -
Flags: review?(karlt)
Updated•9 years ago
|
Attachment #8574873 -
Flags: review?(karlt) → review+
Comment 5•9 years ago
|
||
You should do another try with this patch applied: https://bugzilla.mozilla.org/attachment.cgi?id=8444892 (expect plenty of orange and red, but at least it should build)
Comment 6•9 years ago
|
||
(In reply to Kevin Brosnan [:kbrosnan] from comment #4) > Try looks green. so with comment 5 this needs another try run ?
Flags: needinfo?(kbrosnan)
Keywords: checkin-needed
Comment 7•9 years ago
|
||
You can land this, I verified it works.
Flags: needinfo?(kbrosnan)
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cb314c34f24
Assignee: nobody → kbrosnan
Keywords: checkin-needed
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5cb314c34f24
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•