functional test needs to log more to help debug intermittment

RESOLVED FIXED in Firefox 39

Status

Hello (Loop)
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

unspecified
mozilla39
x86
Mac OS X
Points:
1

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
In local_get_and_verify_room_url, we don't log what the URL is, which is hurting our ability to diagnose an intermittent failure.  Patch forthcoming.
(Assignee)

Comment 1

3 years ago
Created attachment 8574801 [details] [diff] [review]
Improve Hello functional test logging
Attachment #8574801 - Flags: review?(drno)
Comment on attachment 8574801 [details] [diff] [review]
Improve Hello functional test logging

Review of attachment 8574801 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/test/functional/test_1_browser_call.py
@@ +111,5 @@
>          room_url = pyperclip.paste()
>  
>          self.assertIn(urlparse.urlparse(room_url).scheme, ['http', 'https'],
>                        "room URL returned by server " + room_url +
> +                      " has invalid scheme, url = " + room_url)

This does not provide any new information, as the room_url is already included in the message above in line 114. From looking at the log from the test failure it looks like the URL was simply empty. How about we instead enclose the existing room_url in '' or some others quotes?
(Assignee)

Comment 3

3 years ago
Indeed; I should have looked a bit more closely.  I'll do the single quotes.
(Assignee)

Comment 4

3 years ago
Created attachment 8574836 [details] [diff] [review]
Improve Hello functional test logging
Attachment #8574801 - Attachment is obsolete: true
Attachment #8574801 - Flags: review?(drno)
Attachment #8574836 - Flags: review?(drno)
Comment on attachment 8574836 [details] [diff] [review]
Improve Hello functional test logging

Review of attachment 8574836 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8574836 - Flags: review?(drno) → review+
(Assignee)

Updated

3 years ago
Assignee: nobody → dmose
Iteration: --- → 39.2 - 23 Mar
Points: --- → 1
Target Milestone: --- → mozilla39
https://hg.mozilla.org/mozilla-central/rev/e750aa4fc06c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.