Closed Bug 1141229 Opened 7 years ago Closed 7 years ago

functional test needs to log more to help debug intermittment

Categories

(Hello (Loop) :: General, defect)

x86
macOS
defect
Not set
normal
Points:
1

Tracking

(firefox39 fixed)

RESOLVED FIXED
mozilla39
Iteration:
39.2 - 23 Mar
Tracking Status
firefox39 --- fixed

People

(Reporter: dmosedale, Assigned: dmosedale)

Details

Attachments

(1 file, 1 obsolete file)

In local_get_and_verify_room_url, we don't log what the URL is, which is hurting our ability to diagnose an intermittent failure.  Patch forthcoming.
Attachment #8574801 - Flags: review?(drno)
Comment on attachment 8574801 [details] [diff] [review]
Improve Hello functional test logging

Review of attachment 8574801 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/test/functional/test_1_browser_call.py
@@ +111,5 @@
>          room_url = pyperclip.paste()
>  
>          self.assertIn(urlparse.urlparse(room_url).scheme, ['http', 'https'],
>                        "room URL returned by server " + room_url +
> +                      " has invalid scheme, url = " + room_url)

This does not provide any new information, as the room_url is already included in the message above in line 114. From looking at the log from the test failure it looks like the URL was simply empty. How about we instead enclose the existing room_url in '' or some others quotes?
Indeed; I should have looked a bit more closely.  I'll do the single quotes.
Attachment #8574801 - Attachment is obsolete: true
Attachment #8574801 - Flags: review?(drno)
Attachment #8574836 - Flags: review?(drno)
Comment on attachment 8574836 [details] [diff] [review]
Improve Hello functional test logging

Review of attachment 8574836 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8574836 - Flags: review?(drno) → review+
Assignee: nobody → dmose
Iteration: --- → 39.2 - 23 Mar
Points: --- → 1
Target Milestone: --- → mozilla39
https://hg.mozilla.org/mozilla-central/rev/e750aa4fc06c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.