1141251 - Get firefox-ui-tests passing on windows

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Chris Manchester (limited bugmail, email directly)]

The PR in bug 1125732 shows a lot of windows failures. This blocks integration with mozmill ci, hopefully there's a small root cause to iron out.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: PR to fix windows

The build hasn't finished yet, but an earlier version passed ok so let's get this reviewed.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester [:chmanchester] from comment #1)
> Created attachment 8574970 [details] [review]
> PR to fix windows
> 
> The build hasn't finished yet, but an earlier version passed ok so let's get
> this reviewed.

Actually, the build earlier passed all its tests but timed out over the 40 minute threshold on appveyor. The build got to the uninstall step:

https://ci.appveyor.com/project/whimboo/firefox-ui-tests/build/1.0.26

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8574970 [details] [review]
PR to fix windows

Good to see that it was not that hard to investigate and fix. Thanks for doing that! I added some comments on the PR.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8574970 [details] [review]
PR to fix windows

I addressed the comments. Still don't know why this is timing out on AppVeyor, but at least our tests are passing.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8574970 [details] [review]
PR to fix windows

Wonderful! Thanks a lot for your help. I will get it squashed and merged now.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://github.com/mozilla/firefox-ui-tests/commit/045bc69616cdd2a2e731bb99196d55347c82cff8