Upgrade the SSL panel in Privacy & Security preferences to refer to TLS {instead,too}

RESOLVED FIXED in seamonkey2.40

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

Tracking

Trunk
seamonkey2.40
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

28.28 KB, patch
iann_bugzilla
: review+
rsx11m.pub
: ui-review+
Details | Diff | Splinter Review
Assignee

Description

4 years ago
+++ This bug was initially created as a clone of Bug #1137991 +++

(Quoting rsx11m from bug 1137991 comment #4)
> With the term "SSL" officially retiring soon [bug 1106470], I'm wondering
> if we should rename that prefpane (...). On the other hand, "SSL" is a
> reasonably established term, and other browsers/mail programs still use it
> routinely.
> 
> Something like "Transport Layer Security (SSL/TLS)" sounds more clear anyway
> (what's a "Socket" and why does it have to be "Secure"?), or maybe
> "Connection Security (SSL/TLS)" would be least ambiguous (with the short
> panel title in the prefpane tree being "SSL/TLS" or just "Connection
> Security").
Assignee

Comment 1

4 years ago
Posted patch Proposed patch (obsolete) — Splinter Review
This is actually mostly related to Help updates, the label changes are fairly straight-forward. I've left the file names and helpTopic="ssl_prefs" target as they are, modifying those with s/ssl/ssltls/ as well might be painful.

Ian, I've also updated the section on supported SSL and TLS versions in the Certificates Help content which is obsolete now that SSL 3.0 was deprecated.
Attachment #8609069 - Flags: ui-review?(neil)
Attachment #8609069 - Flags: review?(iann_bugzilla)
Assignee

Comment 2

4 years ago
(In reply to rsx11m from comment #1)
> I've left the file names and helpTopic="ssl_prefs" target as they are

The same applies to the prefpane="ssl_pane" identifier, etc.
Comment on attachment 8609069 [details] [diff] [review]
Proposed patch

>+<!ENTITY ssltls.label "SSL / TLS">
I think we should stick with SSl/TLS for consistency.
Attachment #8609069 - Flags: ui-review?(neil) → ui-review+
Assignee

Comment 4

4 years ago
Yeah, the preference category was the first label which I had modified, where "SSL / TLS" looked slightly better to me with those spaces. But then, it looked better without them when "SSL/TLS" was part of the text.
Attachment #8609069 - Attachment is obsolete: true
Attachment #8609069 - Flags: review?(iann_bugzilla)
Attachment #8609633 - Flags: ui-review+
Attachment #8609633 - Flags: review?(iann_bugzilla)
Assignee

Updated

4 years ago
Blocks: 1149581

Updated

4 years ago
Attachment #8609633 - Flags: review?(iann_bugzilla) → review+
Assignee

Comment 5

4 years ago
Thanks for the reviews, push for comm-central please.
Keywords: checkin-needed

Comment 6

4 years ago
a=me for CLOSED TREE

Comment 7

4 years ago
http://hg.mozilla.org/comm-central/rev/1d853191da11
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.40
You need to log in before you can comment on or make changes to this bug.