1141341 - LZMA decoding error

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Tobias Schneider [:tobytailor]]

The following files are LZMA compressed and throw "LZMA decoding error" during parsing:

http://areweflashyet.com/swfs/2f4f4610ee81b767ba568def040430e7e4daefcb11067e707e9e8c2ff94123bf1cd22602efd251acc7d19d9b9a600e41d99bffd7bbf746a6961a676c44b8852b.swf
http://areweflashyet.com/swfs/41ae8b3f00f9fffff8f4d5c03e258b6cbd5072cb3abb0424c7dfa5206d3320f808216a68aa9eaa8861ba54d0067abf0f50af70dbb4e473fa205e085238542f3f.swf
http://areweflashyet.com/swfs/413af83156e405c644132dc5059b5d16ebca1c7127f1063b63f9fe9756efe7a9f0b9758554a0efa49c5352bf0225b2c4ebba93b8c2793c45b612a60d5c0e6732.swf
http://areweflashyet.com/swfs/4102f3bc32069695c21a2cfcd25f4bc827e83db78d452e985ceb5050bd6d514ce2dadf6e221c2b918c5a2122371d00d118313eceda67869417eb0c4144f0feaa.swf
http://areweflashyet.com/swfs/1770096affe5adad4f014b428e67a59a64719ac9d8defb2a79ad57bd7ce54c8827eb9904365ad8497372e4c360675e87d61f4ec2f3d9435ca99b3b0ae9497257.swf
http://areweflashyet.com/swfs/c1511c54f0d94e8dbb5bcfc245e3b4376c9def2a80875b4b1b27b4d840985fa4eaa419c57b61707b2c3dd5ff37f969a908bdd2cdcfad851065ad5754b22d39b4.swf

Comment 1

[Yury Delendik (:yury)]

All the above (except 413af..swf) contain wrong uncompressed size, the packaged uncompressed data is 8 bytes longer than needed and those 8 bytes are always zeros. Looks like some SWF re-compression failed to properly produce a valid SWF. 413af..swf one is incomplete, but still can be played with FP.

Probably we shall stop decompression after first error occurs, and don't produce any visible exception for the user.

Comment 2

[Yury Delendik (:yury)]

https://github.com/mozilla/shumway/pull/2118