1141376 - Stop calling OnSizeAvailable in nsImageFrame::Init

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

After bug 1103157, there's no need to cache the image or call OnSizeAvailable in nsImageFrame::Init. SIZE_AVAILABLE is always delivered now. It was an oversight that this code wasn't removed in that bug.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Do not call OnSizeAvailable in nsImageFrame::Init

Here's the patch.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Thanks for the review! Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/915f028b125e

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/915f028b125e

Comment 4

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8574972 [details] [diff] [review]
Do not call OnSizeAvailable in nsImageFrame::Init

Approval Request Comment
[Feature/regressing bug #]: srcset
[User impact if declined]: Images intermittently fail to display. This is bug 1083072, which is tracked. We want this to come together with bug 1019840, which is the main fix for bug 1083072.
[Describe test coverage new/current, TreeHerder]: On m-c for days now.
[Risks and why]: Should be pretty low risk.
[String/UUID change made/needed]: None.

Comment 5

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8574972 [details] [diff] [review]
Do not call OnSizeAvailable in nsImageFrame::Init

Also requesting approval for b2g37 because we want this in conjunction with bug 1019840.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/813378228975

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b716899d9624