Closed Bug 1141387 Opened 9 years ago Closed 5 years ago

Intermittent background-blending-image-color-gif.html | image comparison (==), max difference: 255, number of differing pixels: 10000

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Version:
39 Branch
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox67 --- fixed
firefox68 --- fixed

People

(Reporter: KWierso, Assigned: hiro)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(3 files)

TEST
5.53 KB, image/png
Details
REFERENCE
5.53 KB, image/png
Details
Bug 1141387 - Set image.animation_mode=none to avoid the animated GIF is advanced to the next frame. r?heycam
47 bytes, text/x-phabricator-request
Details | Review
Attached image TEST — 
12:28:00 INFO - REFTEST TEST-END | http://10.0.2.2:8888/tests/layout/reftests/css-blending/mix-blend-mode-nested-976533.html
12:28:00 INFO - REFTEST TEST-START | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-svg-as-data-uri.html
12:28:00 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-svg-as-data-uri.html | 115 / 555 (20%)
12:28:00 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-ref.html | 115 / 555 (20%)
12:28:00 INFO - REFTEST TEST-PASS | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-svg-as-data-uri.html | image comparison (==)
12:28:00 INFO - REFTEST INFO | Loading a blank page
12:28:00 INFO - REFTEST TEST-END | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-svg-as-data-uri.html
12:28:00 INFO - REFTEST TEST-START | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-gif.html
12:28:00 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-gif.html | 116 / 555 (20%)
12:28:00 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-gif-ref.html | 116 / 555 (20%)
12:28:00 INFO - REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-gif.html | image comparison (==), max difference: 255, number of differing pixels: 10000 
12:28:13 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-gif.html
12:28:13 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
12:28:13 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
12:28:13 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
12:28:13 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
12:28:13 INFO - REFTEST INFO | Saved log: RecordResult fired
12:28:13 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-gif-ref.html
12:28:13 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
12:28:13 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
12:28:13 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
12:28:13 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
12:28:13 INFO - REFTEST INFO | Saved log: RecordResult fired
12:28:13 INFO - REFTEST INFO | Loading a blank page
12:28:13 INFO - REFTEST TEST-END | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-gif.html
12:28:13 INFO - REFTEST TEST-START | http://10.0.2.2:8888/tests/layout/reftests/css-blending/background-blending-image-color-transform3d.html
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3

There are 26 total failures in the last 7 days all on android-em-4-3-armv7-api16 debug

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232940442&repo=autoland&lineNumber=2861

[task 2019-03-10T00:00:41.551Z] 00:00:41 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-svg-as-data-uri.html == http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-ref.html
[task 2019-03-10T00:00:41.551Z] 00:00:41 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif.html == http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif-ref.html
[task 2019-03-10T00:00:41.552Z] 00:00:41 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif.html | 315 / 364 (86%)
[task 2019-03-10T00:00:52.273Z] 00:00:52 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif-ref.html | 315 / 364 (86%)
[task 2019-03-10T00:01:02.995Z] 00:01:02 INFO - REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif.html == http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif-ref.html | image comparison, max difference: 255, number of differing pixels: 10000

[task 2019-03-10T00:01:03.007Z] 00:01:03 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif.html
[task 2019-03-10T00:01:03.008Z] 00:01:03 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2019-03-10T00:01:03.008Z] 00:01:03 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-03-10T00:01:03.009Z] 00:01:03 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2019-03-10T00:01:03.009Z] 00:01:03 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2019-03-10T00:01:03.010Z] 00:01:03 INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-03-10T00:01:03.010Z] 00:01:03 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif-ref.html
[task 2019-03-10T00:01:03.010Z] 00:01:03 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2019-03-10T00:01:03.010Z] 00:01:03 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-03-10T00:01:03.010Z] 00:01:03 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2019-03-10T00:01:03.010Z] 00:01:03 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2019-03-10T00:01:03.011Z] 00:01:03 INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-03-10T00:01:03.011Z] 00:01:03 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif.html == http://10.0.2.2:8854/tests/layout/reftests/css-blending/background-blending-image-color-gif-ref.html

Sean can you assign someone here?

Flags: needinfo?(svoisen)
Whiteboard: [stockwell needswork:owner]

@hiro: I remember that you removed the pref for background blending a little while ago. Any idea why this fails on Android?

Flags: needinfo?(svoisen) → needinfo?(hikezoe)

I totally forgot I did drop the pref. :) Anyway, I can take a look, of course.

Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Flags: needinfo?(hikezoe)

Ok, now I know what's going on there. The reftest has an animated GIF as background-image which contains two animation frames, the one is a red rectangle, the other is a green rectangle. On the other hand, the target element has background-color: rgb(255, 255, 0); background-blend-mode: difference styles, so if the animation frame is the red one, the element is rendered as a green box, if the animation frame is the green one, the element is rendered as a red box. The failure cases here are the red box. I am pretty sure that on Android we sometimes take more time before taking a snapshot for the reftest, so the animated GIF is advanced to the next frame that actually we don't suppose.

I think just adding image.animation_mode=none pref solves this failure and it doesn't mean to break the test purpose.

The animated GIF in background-blending-image-color-gif.html has two animation
frames, the one is a red rectangle, the other is a green rectangle. The reftest
is supposed to take the snapshot during the time where the animation frame is
the red rectangle (the first frame) and the frame duration is 1000ms. So if we
take over 1000ms there for some reasons, say on slow platforms, before taking
the snapshot, the reftet fails.

Cameron, just in case you are not aware of the review request.

Flags: needinfo?(cam)

Thanks, got behind on reviews.

Flags: needinfo?(cam)

Thanks. :)

Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4eb705fd67f6
Set image.animation_mode=none to avoid the animated GIF is advanced to the next frame. r=heycam

https://hg.mozilla.org/mozilla-central/rev/4eb705fd67f6

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: