1141410 - [traceback] UnicodeDecodeError when putting together url invalid error

Status: RESOLVED FIXED

(Input Graveyard :: Code Quality, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Saw a couple of these over the last month:

...
  File "/data/www/input.mozilla.org/input/vendor/src/django-rest-framework/rest_framework/serializers.py", line 546, in errors
    ret = self.from_native(data, files)
  File "/data/www/input.mozilla.org/input/vendor/src/django-rest-framework/rest_framework/serializers.py", line 374, in from_native
    attrs = self.perform_validation(attrs)
  File "/data/www/input.mozilla.org/input/vendor/src/django-rest-framework/rest_framework/serializers.py", line 307, in perform_validation
    attrs = validate_method(attrs, source)
  File "/data/www/input.mozilla.org/input/fjord/feedback/models.py", line 662, in validate_url
    '{0} is not a valid url'.format(value))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe4' in position 8: ordinal not in range(128)

Need to fix that so it handles urls correctly.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P2 because it's worth fixing asap and I suspect it's a straight-forward fix.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I talked to L Guruprasad about this on IRC and I think he agreed to take it, so I'm assigning it to him.

LGuruprasad: If you have questions or issues, let me know.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/524

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master: https://github.com/mozilla/fjord/commit/7fa256a654e5a32dea4eb87857dc73b531656e62

Will push out next deploy.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed just now!