1141457 - Refactor receiveMessage in Nfc.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Make receiveMesssage easier in Nfc.js

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Move SendFile to gMessageManager

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: add isP2P for writeNDEF.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: add a CommandMsgTable.

Comment 4

[Dimi Lee [:dimi]]

Comment on attachment 8575174 [details] [diff] [review]
Part 3: add a CommandMsgTable.

Review of attachment 8575174 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/gonk/Nfc.js
@@ +96,5 @@
> +CommandMsgTable["NFC:ReadNDEF"] = NfcRequestType.READ_NDEF;
> +CommandMsgTable["NFC:WriteNDEF"] = NfcRequestType.WRITE_NDEF;
> +CommandMsgTable["NFC:MakeReadOnly"] = NfcRequestType.MAKE_READ_ONLY;
> +CommandMsgTable["NFC:Format"] = NfcRequestType.FORMAT;
> +CommandMsgTable["NFC:Transceive"] = NfcRequestType.TRANSCEIVE;

I am not sure if overwrite a const dictionary after declaration works according to
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const

No matter if it works i suggest we declare like this:
const CommandMsgTable = {
  "NFC:ChangeRFState":NfcRequestType.CHANGE_RF_STATE,
  ...
}

Comment 5

[Dimi Lee [:dimi]]

(In reply to Dimi Lee[:dimi][:dlee] from comment #4)
> Comment on attachment 8575174 [details] [diff] [review]
> Part 3: add a CommandMsgTable.
> 
> Review of attachment 8575174 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/nfc/gonk/Nfc.js
> @@ +96,5 @@
> > +CommandMsgTable["NFC:ReadNDEF"] = NfcRequestType.READ_NDEF;
> > +CommandMsgTable["NFC:WriteNDEF"] = NfcRequestType.WRITE_NDEF;
> > +CommandMsgTable["NFC:MakeReadOnly"] = NfcRequestType.MAKE_READ_ONLY;
> > +CommandMsgTable["NFC:Format"] = NfcRequestType.FORMAT;
> > +CommandMsgTable["NFC:Transceive"] = NfcRequestType.TRANSCEIVE;
> 
> I am not sure if overwrite a const dictionary after declaration works
> according to
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/
> const
> 
> No matter if it works i suggest we declare like this:
> const CommandMsgTable = {
>   "NFC:ChangeRFState":NfcRequestType.CHANGE_RF_STATE,
>   ...
> }

Forget this comment, const object could reassign its property

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a8e070c7f67c
https://hg.mozilla.org/integration/b2g-inbound/rev/13a7f7c81a18
https://hg.mozilla.org/integration/b2g-inbound/rev/dd4a99b9a08f

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a8e070c7f67c
https://hg.mozilla.org/mozilla-central/rev/13a7f7c81a18
https://hg.mozilla.org/mozilla-central/rev/dd4a99b9a08f