Closed Bug 1141480 Opened 9 years ago Closed 9 years ago

[Stingray][Home] Add Unit tests for home.js

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Home
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rexboy, Assigned: rexboy)

References

Details

Attachments

(2 files)

[gaia] rexboy7:home-unit-test-3 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review
Patch
46 bytes, text/x-github-pull-request
dwi2
: review+
Details | Review 
Add unit tests for home.js.
Cover possible cases as possible. To cover the whole file, many cases will be related with the original file. So we can see this bug as "round 1" and open follow-up bugs if required.
Blocks: 1141478
No longer depends on: 1141478
Summary: [Meta][Stingray][Home] Add Unit tests for home.js → [Stingray][Home] Add Unit tests for home.js
Attached file Patch — 
Hi dwi2,
I tried to put on a unit-test patch.
Sorry for a big one :-/ you can put it off if you are not available.
Attachment #8634037 - Flags: review?(tzhuang)
Comment on attachment 8634037 [details] [review]
Patch

Generally it looks good to me. Please address comments on PR before landing.

Thanks
Attachment #8634037 - Flags: review?(tzhuang) → review+
Thanks for reviewing the patch. I just addressed your comments and leave some TODO there to confirm we won't forget to add remaining cases.

landed on master:
https://github.com/mozilla-b2g/gaia/commit/4cddebb56792a15619fdc34db790c6d014cb8e3c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: