Closed Bug 1141509 Opened 5 years ago Closed 5 years ago

Height is spelt wrong in css for resized chat window

Categories

(Hello (Loop) :: Client, defect, P5)

defect
Points:
1

Tracking

(firefox39 fixed)

RESOLVED FIXED
mozilla39
Iteration:
39.2 - 23 Mar
Tracking Status
firefox39 --- fixed

People

(Reporter: standard8, Assigned: jaws)

References

Details

(Whiteboard: [UX bug])

Attachments

(1 file)

In bug 1081847 we attempted to change the size of the chat window to 300w x 272h.

Unfortunately there was a typo in the css and we failed to set the height correctly - so the height is still 285px.

I've had a look, and if I fix the css, then in addition to the width-extending sideways when the conversation window is displayed, there's a slight shortening of the height as well.

I looked at various options with the css transistions - which are meant to animate from normal to minimised and vice-versa - but I can't see a realistic way to get around this, without separating out the styles a lot more.

Sevaan, would you be happy with 300w x 285h, or do you want us to attempt to do the 272 height?

We should do at least something (remove our special case for height or make it work), due to the typo in the code.
Flags: needinfo?(sfranks)
So should I correct the summary s/spelt/spelled/ now, seriously? :-P
(In reply to Mike de Boer [:mikedeboer] from comment #1)
> So should I correct the summary s/spelt/spelled/ now, seriously? :-P

Remember, I'm British: http://www.oxforddictionaries.com/definition/english/spelt
Blocks: 1081847
No longer depends on: 1081847
I'm happy with the 285 height. Thanks!
Flags: needinfo?(sfranks)
Attached patch PatchSplinter Review
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8580392 - Flags: review?(standard8)
Iteration: --- → 39.2 - 23 Mar
Points: --- → 1
Flags: firefox-backlog+
Comment on attachment 8580392 [details] [diff] [review]
Patch

Review of attachment 8580392 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I hadn't got back around to this one.
Attachment #8580392 - Flags: review?(standard8) → review+
https://hg.mozilla.org/mozilla-central/rev/e851320aec2b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.