1141509 - Height is spelt wrong in css for resized chat window

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P5)

Description

[Mark Banner (:standard8)]

In bug 1081847 we attempted to change the size of the chat window to 300w x 272h.

Unfortunately there was a typo in the css and we failed to set the height correctly - so the height is still 285px.

I've had a look, and if I fix the css, then in addition to the width-extending sideways when the conversation window is displayed, there's a slight shortening of the height as well.

I looked at various options with the css transistions - which are meant to animate from normal to minimised and vice-versa - but I can't see a realistic way to get around this, without separating out the styles a lot more.

Sevaan, would you be happy with 300w x 285h, or do you want us to attempt to do the 272 height?

We should do at least something (remove our special case for height or make it work), due to the typo in the code.

Comment 1

[Mike de Boer [:mikedeboer]]

So should I correct the summary s/spelt/spelled/ now, seriously? :-P

Comment 2

[Mark Banner (:standard8)]

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> So should I correct the summary s/spelt/spelled/ now, seriously? :-P

Remember, I'm British: http://www.oxforddictionaries.com/definition/english/spelt

Comment 3

[Sevaan Franks [:sevaan]]

I'm happy with the 285 height. Thanks!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8580392 [details] [diff] [review]
Patch

Review of attachment 8580392 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I hadn't got back around to this one.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/e851320aec2b

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e851320aec2b