1141516 - shell/futex.js permafail when pushing non-trunk branches to Try

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1135368 +++

Looks like bug 1135368 isn't working. I'm seeing permafail on all non-trunk branches when I run SM jobs on them on Try.

https://treeherder.mozilla.org/logviewer.html#?job_id=5510143&repo=try

TEST-UNEXPECTED-FAIL | shell/futex.js | (args: "")
TEST-UNEXPECTED-FAIL | shell/futex.js | (args: "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads")
TEST-UNEXPECTED-FAIL | shell/futex.js | (args: "--ion-eager --ion-offthread-compile=off")
TEST-UNEXPECTED-FAIL | shell/futex.js | (args: "--baseline-eager --no-fpu")
TEST-UNEXPECTED-FAIL | shell/futex.js | (args: "--no-baseline --no-ion")
TEST-UNEXPECTED-FAIL | shell/futex.js | (args: "--baseline-eager")

Comment 1

[Lars T Hansen [:lth]]

The problem is that in the case of the early-out (non-Nightly), there is no call to reportCompare(), so the test driver gets upset.

The lack of a reportCompare() call probably came about because we don't need one in jit-test/, and we've gotten used to not worrying about it when writing guards for test cases.

Comment 2

[Lars T Hansen [:lth]]

Attachment: bug1141516-reportCompare.diff

I've reproduced the reported error on mozilla-inbound my manipulating config/milestone.txt, and I've verified that the attached patch then makes the error go away.

Comment 3

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08f20332d65d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d3939281285d

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/08f20332d65d