Closed Bug 1141533 Opened 10 years ago Closed 10 years ago

Cache busting isn't enabled for perf.min.js

Categories

(Tree Management :: Perfherder, defect, P1)

Product:
Tree Management
Component:
Perfherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

Details

Attachments

(1 file)

Enable cache busting for perf.min.js
49 bytes, text/x-github-pull-request
wlach
: review+
Details | Review
[~/src/treeherder-ui/dist/js]$ ls -l total 1788 -rwxrwx---+ 1 Ed None 673922 Mar 10 12:10 index.min-c1323f0b71844e3772121784322db648.js -rwxrwx---+ 1 Ed None 510479 Mar 10 12:10 logviewer.min-32cca93d076544abc4e9533a38cdf12f.js -rwxrwx---+ 1 Ed None 639157 Mar 10 12:10 perf.min.js This will cause problems now that js/css expire times have been set to a large value in bug 1119749.
Attachment #8575283 - Flags: review?(wlachance)
Comment on attachment 8575283 [details] [review] Enable cache busting for perf.min.js Awesome, thanks!
Attachment #8575283 - Flags: review?(wlachance) → review+
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/0653660f982bcf1b4eda7ca09312b46cded078b7 Bug 1141533 - Enable cache busting for perf.min.js All of the other js files are given filenames containing their hashes, during the grunt build, in order to prevent over-caching. This makes us do the same for perf.min.js too.
Np :-)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/fef2b0f0377c720c6210ca2e125117dd9c8ade3e Bug 1141533 - Enable cache busting for perf.min.js All of the other js files are given filenames containing their hashes, during the grunt build, in order to prevent over-caching. This makes us do the same for perf.min.js too.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: