1141573 - [MozDevice] Accept variables from the environment to set adb host and port in commands

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[:Eli Perelman]

For automation there is going to be a new remote device lab in which commands are not sent to a direct device connection but rather are done via host and port connection. Raptor needs to accept environment variables for these arguments.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/11

This patch allows Raptor to run commands against a remote device by specifying the environment variables ADB_HOST and ADB_PORT to the test in Gaia, e.g.:

ADB_HOST=192.168.1.10 ADB_PORT=5037 DEBUG=* RUNS=1 APP=clock node tests/raptor/launch_test

After getting a remote device working and specifying -H and -P on each command, I was surprised by how seamlessly this operated; it really felt like the device was still on my local machine. :D

Comment 2

[:Eli Perelman]

You can save from having to put ADB_HOST and ADB_PORT in the command line constantly by placing them with .env file variables that the other Raptor env variables use.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8577283 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/11

Looks great, thanks Eli!

Comment 4

[Robert Wood [:rwood]]

Comment on attachment 8577283 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/11

LGTM and R+ based on that you tested it out with your own remote device setup.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia-node-modules] eliperelman:bug-1141573 > mozilla-b2g:master

Comment 6

[:Eli Perelman]

Comment on attachment 8580711 [details] [review]
[gaia-node-modules] eliperelman:bug-1141573 > mozilla-b2g:master

Carrying over r+ for package bump.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] eliperelman:bug-1141573 > mozilla-b2g:master

Comment 8

[:Eli Perelman]

Comment on attachment 8580713 [details] [review]
[gaia] eliperelman:bug-1141573 > mozilla-b2g:master

Carrying over r+ for package bump.

Comment 9

[:Eli Perelman]

In master: https://github.com/mozilla-b2g/gaia/commit/69c230da400089c4311ce82867e26f266e648c6f